Fix import_dashboard_template_lakeview#343
Open
chunheisiu wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes SAT initializer notebook failures when importing the Lakeview dashboard by reliably detecting an existing dashboard and aligning error handling with the actual API error code.
Changes:
- Adds pagination + rate-limit retry/backoff when listing Lakeview dashboards to find an existing “Security Analysis Tool [SAT]” dashboard.
- Updates the “already exists” detection from
RESOURCE_ALREADY_EXISTStoALREADY_EXISTS. - Minor whitespace/formatting cleanups.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
@shreelshah12 will review, test and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #342
Type of Change
How Has This Been Tested?
Tested in workspace hosted in Azure by running initializer notebook and run succeeded.
Checklist
Screenshots (If Applicable)
Additional Notes
Sample response from current cell 17 when a dashboard with the same name exists:
{"error_code":"ALREADY_EXISTS","message":"A node with name 'Security Analysis Tool [SAT]' already exists under the specified parent","details":[{"@type":"type.googleapis.com/google.rpc.RequestInfo","request_id":"991090d0-efa4-4498-920a-2f0457bb9044","serving_data":""}]}