Skip to content

Fix import_dashboard_template_lakeview#343

Open
chunheisiu wants to merge 3 commits into
databricks-industry-solutions:mainfrom
chunheisiu:fix-dashboard
Open

Fix import_dashboard_template_lakeview#343
chunheisiu wants to merge 3 commits into
databricks-industry-solutions:mainfrom
chunheisiu:fix-dashboard

Conversation

@chunheisiu

@chunheisiu chunheisiu commented May 11, 2026

Copy link
Copy Markdown

Description

Fixes #342

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (non-code changes like README or docs)

How Has This Been Tested?

Tested in workspace hosted in Azure by running initializer notebook and run succeeded.

Checklist

  • I have reviewed the CONTRIBUTING and VERSIONING documentation.
  • My code follows the code style of this project.
  • I have verified, added or updated the tests to cover my changes (if applicable).
  • I have verified that my changes do not introduce any breaking changes on all the supported clouds (AWS, Azure, GCP).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).

Screenshots (If Applicable)

Additional Notes

Sample response from current cell 17 when a dashboard with the same name exists:

{"error_code":"ALREADY_EXISTS","message":"A node with name 'Security Analysis Tool [SAT]' already exists under the specified parent","details":[{"@type":"type.googleapis.com/google.rpc.RequestInfo","request_id":"991090d0-efa4-4498-920a-2f0457bb9044","serving_data":""}]}

Copilot AI review requested due to automatic review settings May 11, 2026 06:49
@CLAassistant

CLAassistant commented May 11, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes SAT initializer notebook failures when importing the Lakeview dashboard by reliably detecting an existing dashboard and aligning error handling with the actual API error code.

Changes:

  • Adds pagination + rate-limit retry/backoff when listing Lakeview dashboards to find an existing “Security Analysis Tool [SAT]” dashboard.
  • Updates the “already exists” detection from RESOURCE_ALREADY_EXISTS to ALREADY_EXISTS.
  • Minor whitespace/formatting cleanups.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread notebooks/Setup/5. import_dashboard_template_lakeview.py Outdated
Comment thread notebooks/Setup/5. import_dashboard_template_lakeview.py
chunheisiu and others added 2 commits May 11, 2026 14:53
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@arunpamulapati

Copy link
Copy Markdown
Collaborator

@shreelshah12 will review, test and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SAT Initializer notebook failed to locate existing dashboard

4 participants