Skip to content

Fix Permissions Analysis Tool app#345

Open
chunheisiu wants to merge 3 commits into
databricks-industry-solutions:mainfrom
chunheisiu:fix-app
Open

Fix Permissions Analysis Tool app#345
chunheisiu wants to merge 3 commits into
databricks-industry-solutions:mainfrom
chunheisiu:fix-app

Conversation

@chunheisiu

Copy link
Copy Markdown

Description

Fix the following issues with the Permissions Analysis Tool app:

  1. Added a resource type mapping to map Warehouse to SQLWarehouse to match with API response.
    The brickhound_vertices table has no node_type = 'Warehouse', only SQLWarehouse. Thus, adding this mapping so that relevant SQL warehouses records are correctly returned.
  2. Added missing resource types emojis.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (non-code changes like README or docs)

How Has This Been Tested?

Checklist

  • I have reviewed the CONTRIBUTING and VERSIONING documentation.
  • My code follows the code style of this project.
  • I have verified, added or updated the tests to cover my changes (if applicable).
  • I have verified that my changes do not introduce any breaking changes on all the supported clouds (AWS, Azure, GCP).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).

Screenshots (If Applicable)

Additional Notes

Copilot AI review requested due to automatic review settings May 11, 2026 08:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix BrickHound (Permissions Analysis Tool) UI/resource-type mismatches by normalizing Warehouse resource types to match collected/API data and by expanding the set of resource-type emojis shown in the app.

Changes:

  • Introduces a backend resource-type mapping (WarehouseSQLWarehouse) and a reverse display mapping for response payloads.
  • Updates UI emoji/icon handling by delegating most resource-type icons to getResourceIcon(...).
  • Minor UI string/formatting tweaks and a small config comment correction in app.yaml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
app/brickhound/app.yaml Fixes a typo in an example comment (still has a small wording issue).
app/brickhound/app.py Adds backend resource-type mapping + display mapping; extends resource-type emoji coverage and adjusts UI rendering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/brickhound/app.py Outdated
Comment thread app/brickhound/app.yaml
Comment thread app/brickhound/app.py
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@chunheisiu chunheisiu changed the title Fix app Fix Permissions Analysis Tool app May 11, 2026
@arunpamulapati

Copy link
Copy Markdown
Collaborator

@arunpamulapati will review and test.
Thank you for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants