Fix Permissions Analysis Tool app#345
Open
chunheisiu wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix BrickHound (Permissions Analysis Tool) UI/resource-type mismatches by normalizing Warehouse resource types to match collected/API data and by expanding the set of resource-type emojis shown in the app.
Changes:
- Introduces a backend resource-type mapping (
Warehouse→SQLWarehouse) and a reverse display mapping for response payloads. - Updates UI emoji/icon handling by delegating most resource-type icons to
getResourceIcon(...). - Minor UI string/formatting tweaks and a small config comment correction in
app.yaml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/brickhound/app.yaml | Fixes a typo in an example comment (still has a small wording issue). |
| app/brickhound/app.py | Adds backend resource-type mapping + display mapping; extends resource-type emoji coverage and adjusts UI rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
@arunpamulapati will review and test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the following issues with the Permissions Analysis Tool app:
WarehousetoSQLWarehouseto match with API response.The
brickhound_verticestable has nonode_type = 'Warehouse', onlySQLWarehouse. Thus, adding this mapping so that relevant SQL warehouses records are correctly returned.Type of Change
How Has This Been Tested?
Checklist
Screenshots (If Applicable)
Additional Notes