Patch admin cost page so it no longer blocks other API calls#231
Open
mpkrass7 wants to merge 4 commits into
Open
Patch admin cost page so it no longer blocks other API calls#231mpkrass7 wants to merge 4 commits into
mpkrass7 wants to merge 4 commits into
Conversation
41eb73a to
ef18fd7
Compare
… marshall/patch_cost_router
Author
|
Adding in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #229
https://databricks.slack.com/archives/C0AK9GCFQMV/p1781706581725879

TL/DR there's a bunch of async routes defined for not async in the cost tab. When you define a function as async and run it, you effectively tell fastapi to run the function until it hits an
awaitstep. Then it can hand it off. Since there aren't await steps in the longer running functions, we run into this big blocking issue that makes nothing else load when you leave the tab. And you will leave the tab by the way, because these queries take a long time to run.The claudes tell me the simple fix is to just get rid of the async defs and let fastapi figure it out in its own threadpool.
See the tldr page here: https://fastapi.tiangolo.com/async/
top spenders gets to stay defined with async since it actually does some async operations already
Network activity after fix