docs: trim redundant comments and convert render-types doc to JSDoc

Drop comments that restated adjacent JSDoc/functions:
- base.tsx: the inline-handler re-subscribe rationale lived in both the
  `interactive` and `onEvents` comments; keep it once at `onEvents` (where
  the subscription happens) and point the `interactive` note at it.
- use-metric-view.ts: result-branch comment re-explained metadata narrowing
  already documented on `asMetricMetadata`; defer to that doc.
- js/format/index.ts: call-site comment restated `currencyPrefix`'s own JSDoc.
- render-types.ts: convert `generateMetricTypeDeclarations`'s // block to
  /** */ so the exported function's rationale surfaces on IDE hover.

Co-authored-by: Isaac
Signed-off-by: Atila Fassina <atila@fassina.eu>

Author: atilafassina

packages/appkit-ui/src/js/format/index.ts

@@ -81,9 +81,6 @@ export function formatValue(value: unknown, format?: string): string {
   const isPercent = format.includes("%");
   const grouping = format.includes(",");
   const decimals = countDecimals(format);
-  // Any leading symbol (before the first digit placeholder) is a currency
-  // prefix — emit it verbatim so non-USD symbols the generator produces are
-  // preserved instead of collapsing to "$".
   const prefix = currencyPrefix(format);
 
   // bigint fast path. A bigint is an exact integer, so `BigInt.toLocaleString`

packages/appkit-ui/src/react/charts/base.tsx

@@ -233,11 +233,10 @@ export function BaseChart({
   const ui = useChartUITokens();
 
   // Only the *presence* of a click handler shapes the option (it flips
-  // `triggerLineEvent`/`symbolSize` on line/area) AND the `onEvents` map below.
-  // Depend on this boolean, not the handler reference — consumers pass an inline
-  // `onDataClick`, whose identity changes every render, so depending on the
-  // reference would rebuild the whole option object AND re-subscribe the ECharts
-  // click listener on every parent re-render (e.g. each SSE tick).
+  // `triggerLineEvent`/`symbolSize` on line/area) AND gates the `onEvents` map
+  // below. Depend on this boolean, not the handler reference, so an inline
+  // `onDataClick` (new identity every render) doesn't rebuild the option object
+  // each render — see `onEvents` for the matching subscription rationale.
   const interactive = !!onDataClick;
 
   // Keep the latest handler in a ref so `onEvents` can call the current

packages/appkit-ui/src/react/hooks/use-metric-view.ts

@@ -98,10 +98,7 @@ function handleMetricSseMessage(
   // optional array of unknown values), so a shallow structural check is enough
   // here rather than a full schema validator. Missing or non-array `data`
   // normalizes to [] so `undefined` never bleeds into the hook's `T | null`
-  // state. `metadata` (per-column display metadata scoped to the queried
-  // columns) is surfaced as-is only when it is a plain object; anything else
-  // (null / array / scalar) is treated as absent. It is `undefined` when the
-  // server injected none (dormant / unknown key).
+  // state. `metadata` is narrowed by `asMetricMetadata` (see its doc).
   if (parsed.type === "result") {
     ctx.setLoading(false);
     // A successful result supersedes any error from a prior (retried) attempt —

packages/appkit/src/type-generator/mv-registry/render-types.ts

@@ -236,15 +236,17 @@ ${entries};
 `;
 }
 
-// Build the full metric-views.ts file from a list of metric schemas.
-//
-// This is a real `.ts` source file (not a `.d.ts`), so it carries BOTH the
-// erasable `declare module` type augmentation AND a runtime value export
-// (`metricViewsMetadata`). It must therefore never emit a runtime side-effect
-// import — a bare `import "@databricks/appkit-ui/react"` would execute the
-// client package entry on the Node server. The header is a type-only
-// `import type {} from "..."`, which (a) compiles to zero runtime code and
-// (b) anchors the module so the global `declare module` augmentation resolves.
+/**
+ * Build the full metric-views.ts file from a list of metric schemas.
+ *
+ * This is a real `.ts` source file (not a `.d.ts`), so it carries BOTH the
+ * erasable `declare module` type augmentation AND a runtime value export
+ * (`metricViewsMetadata`). It must therefore never emit a runtime side-effect
+ * import — a bare `import "@databricks/appkit-ui/react"` would execute the
+ * client package entry on the Node server. The header is a type-only
+ * `import type {} from "..."`, which (a) compiles to zero runtime code and
+ * (b) anchors the module so the global `declare module` augmentation resolves.
+ */
 export function generateMetricTypeDeclarations(
   schemas: MetricSchema[],
 ): string {