fix(cli): match lint test-file exclusion relative to scan root (#490)

* fix(cli): match lint test-file exclusion relative to scan root

isTestFile substring-matched "/tests/" against the absolute path, so any
ancestor directory named tests (e.g. ~/Developer/tests/my-app) classified
every file in the project as a test file and silently disabled all
includeTests:false rules (no-variants-in-prod, no-as-any).

Match against the path relative to the scan root with path-segment
boundaries instead, so only the project's own test files and tests/ dirs
are excluded.

Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>

---------

Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
Co-authored-by: MarioCadenas <MarioCadenas@users.noreply.github.com>

Author: MarioCadenas

packages/shared/src/cli/commands/lint.ts

@@ -40,9 +40,11 @@ const rules: Rule[] = [
   },
 ];
 
-function isTestFile(filePath: string): boolean {
+function isTestFile(filePath: string, rootDir: string): boolean {
+  // Relative to scan root: an ancestor `tests` dir must not mark the whole project as tests.
+  const rel = path.relative(rootDir, filePath);
   return (
-    /\.(test|spec)\.(ts|tsx)$/.test(filePath) || filePath.includes("/tests/")
+    /\.(test|spec)\.(ts|tsx)$/.test(rel) || /(^|[/\\])tests[/\\]/.test(rel)
   );
 }
 
@@ -73,11 +75,15 @@ interface Violation {
   code: string;
 }
 
-function lintFile(filePath: string, rules: Rule[]): Violation[] {
+function lintFile(
+  filePath: string,
+  rules: Rule[],
+  rootDir: string,
+): Violation[] {
   const violations: Violation[] = [];
   const content = fs.readFileSync(filePath, "utf-8");
   const lang = filePath.endsWith(".tsx") ? Lang.Tsx : Lang.TypeScript;
-  const testFile = isTestFile(filePath);
+  const testFile = isTestFile(filePath, rootDir);
 
   const ast = parse(lang, content);
   const root = ast.root();
@@ -120,7 +126,7 @@ function runLint() {
   const allViolations: Violation[] = [];
 
   for (const file of files) {
-    const violations = lintFile(file, rules);
+    const violations = lintFile(file, rules, rootDir);
     allViolations.push(...violations);
   }