Skip to content

Commit 8235b07

Browse files
committed
fix: align TEMPLATE_SCAFFOLDING flag required to false; resync template
CI sync:template diff check caught two source/template drifts on 4ae1741: 1. lakebase manifest had been moved must -> should in the source, but the committed template still carried the rule under must. Resyncing now that sync:template is invoked as part of pnpm build. 2. TEMPLATE_SCAFFOLDING declared --template-dir and --config-dir as required: true, but the committed template had them as required: false (per MarioCadenas on PR #261 #6 — these flags aren't actually required by databricks apps init). Flipping the source constant to match; resync now produces consistent output. After this commit, source and template are in lockstep; CI sync:template diff check should pass. Co-authored-by: Isaac Signed-off-by: Atila Fassina <atila@fassina.eu>
1 parent 4ae1741 commit 8235b07

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

packages/shared/src/schemas/manifest.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1050,11 +1050,11 @@ export const TEMPLATE_SCAFFOLDING = {
10501050
flags: {
10511051
"--template-dir": {
10521052
description: "Path to the template directory containing the app scaffold",
1053-
required: true,
1053+
required: false,
10541054
},
10551055
"--config-dir": {
10561056
description: "Path to the output directory for the initialized app",
1057-
required: true,
1057+
required: false,
10581058
},
10591059
"--profile": {
10601060
description: "Databricks CLI profile to use for authentication",

template/appkit.plugins.json

Lines changed: 1 addition & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)