Skip to content

Commit c9d5cda

Browse files
authored
feat(lakebase): support CJS consumers and validate exports via attw (#408)
1 parent a1ea023 commit c9d5cda

6 files changed

Lines changed: 100 additions & 16 deletions

File tree

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
]
5656
},
5757
"devDependencies": {
58+
"@arethetypeswrong/core": "0.18.4",
5859
"@biomejs/biome": "2.2.6",
5960
"@commitlint/cli": "19.8.1",
6061
"@commitlint/config-conventional": "19.8.1",

packages/appkit-ui/tsdown.config.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ import { defineConfig } from "tsdown";
33
export default defineConfig([
44
{
55
publint: true,
6+
attw: {
7+
profile: "esm-only",
8+
level: "error",
9+
excludeEntrypoints: ["./styles.css"],
10+
},
611
name: "@databricks/appkit-ui",
712
entry: [
813
"src/js/index.ts",

packages/appkit/tsdown.config.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ import { defineConfig } from "tsdown";
33
export default defineConfig([
44
{
55
publint: true,
6+
attw: {
7+
profile: "esm-only",
8+
level: "error",
9+
excludeEntrypoints: ["./type-generator"],
10+
},
611
name: "@databricks/appkit",
712
entry: ["src/index.ts", "src/beta.ts"],
813
outDir: "dist",

packages/lakebase/package.json

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
"type": "module",
44
"version": "0.3.0",
55
"description": "PostgreSQL driver for Databricks Lakebase Autoscaling with automatic OAuth token refresh",
6-
"main": "./dist/index.js",
6+
"main": "./dist/index.cjs",
7+
"module": "./dist/index.js",
78
"types": "./dist/index.d.ts",
89
"packageManager": "pnpm@10.21.0",
910
"repository": {
@@ -30,9 +31,15 @@
3031
],
3132
"exports": {
3233
".": {
33-
"types": "./dist/index.d.ts",
3434
"development": "./src/index.ts",
35-
"default": "./dist/index.js"
35+
"import": {
36+
"types": "./dist/index.d.ts",
37+
"default": "./dist/index.js"
38+
},
39+
"require": {
40+
"types": "./dist/index.d.cts",
41+
"default": "./dist/index.cjs"
42+
}
3643
},
3744
"./package.json": "./package.json"
3845
},
@@ -56,10 +63,18 @@
5663
"devDependencies": {
5764
"@types/pg": "8.16.0"
5865
},
59-
"module": "./dist/index.js",
6066
"publishConfig": {
6167
"exports": {
62-
".": "./dist/index.js",
68+
".": {
69+
"import": {
70+
"types": "./dist/index.d.ts",
71+
"default": "./dist/index.js"
72+
},
73+
"require": {
74+
"types": "./dist/index.d.cts",
75+
"default": "./dist/index.cjs"
76+
}
77+
},
6378
"./package.json": "./package.json"
6479
}
6580
}

packages/lakebase/tsdown.config.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,15 @@ import { defineConfig } from "tsdown";
33
export default defineConfig([
44
{
55
publint: true,
6+
attw: {
7+
profile: "strict",
8+
level: "error",
9+
},
610
name: "@databricks/lakebase",
711
entry: "src/index.ts",
812
outDir: "dist",
913
hash: false,
10-
format: "esm",
14+
format: ["esm", "cjs"],
1115
platform: "node",
1216
minify: false,
1317
dts: {
@@ -17,8 +21,8 @@ export default defineConfig([
1721
clean: false,
1822
unbundle: true,
1923
noExternal: [],
20-
outExtensions: () => ({
21-
js: ".js",
24+
outExtensions: ({ format }) => ({
25+
js: format === "cjs" ? ".cjs" : ".js",
2226
}),
2327
external: (id) => {
2428
// Bundle all internal modules

pnpm-lock.yaml

Lines changed: 62 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)