rewrite to return early

denik · denik · commit 06937bcf8958 · 2025-08-18T11:15:10.000+02:00
diff --git a/libs/diag/sdk_error.go b/libs/diag/sdk_error.go
@@ -26,14 +26,12 @@ func findApiErr(e error) *apierr.APIError {
 }
 
 func FormatAPIErrorSummary(e error) string {
-	extra := ""
 	apiErr := findApiErr(e)
-	if apiErr != nil {
-		extra = strings.TrimSpace(fmt.Sprintf("%d %s", apiErr.StatusCode, apiErr.ErrorCode))
-		extra = " (" + extra + ")"
+	if apiErr == nil {
+		return e.Error()
 	}
-
-	return e.Error() + extra
+	extra := strings.TrimSpace(fmt.Sprintf("%d %s", apiErr.StatusCode, apiErr.ErrorCode))
+	return e.Error() + " (" + extra + ")"
 }
 
 func FormatAPIErrorDetails(e error) string {

Original file line number	Diff line number	Diff line change
`@@ -26,14 +26,12 @@ func findApiErr(e error) *apierr.APIError {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`func FormatAPIErrorSummary(e error) string {`
`29`		`- extra := ""`
`30`	`29`	`apiErr := findApiErr(e)`
`31`		`- if apiErr != nil {`
`32`		`- extra = strings.TrimSpace(fmt.Sprintf("%d %s", apiErr.StatusCode, apiErr.ErrorCode))`
`33`		`- extra = " (" + extra + ")"`
	`30`	`+ if apiErr == nil {`
	`31`	`+ return e.Error()`
`34`	`32`	`}`
`35`		`-`
`36`		`- return e.Error() + extra`
	`33`	`+ extra := strings.TrimSpace(fmt.Sprintf("%d %s", apiErr.StatusCode, apiErr.ErrorCode))`
	`34`	`+ return e.Error() + " (" + extra + ")"`
`37`	`35`	`}`
`38`	`36`
`39`	`37`	`func FormatAPIErrorDetails(e error) string {`