filer: restore INVALID_PARAMETER_VALUE branch (it does fire, with overwrite=true)

Previous commit (687c731) called the INVALID_PARAMETER_VALUE branch dead
code based on conflict scenarios that didn't pass overwrite=true. Re-probing
with overwrite=true (the mode bundle deploy uses) shows the server does
return 400 INVALID_PARAMETER_VALUE for cross-type collisions, in two
distinct message shapes:

  "Cannot overwrite the asset at X due to type mismatch (asked: ..., actual: ...)"
  "Requested node type [...] is different from the existing node type [...]"

Both fire only when the existing object's node type differs from the upload
(NOTEBOOK at /a/foo, regular-content overwrite-upload to /a/foo or /a/foo.py).
Without overwrite=true, the same scenario surfaces as RESOURCE_ALREADY_EXISTS
or ALREADY_EXISTS — which is why the no-overwrite probe missed this branch.

Restore the mapping (returning fileAlreadyExistsError so the caller's
errors.Is(err, fs.ErrExist) check still fires) and broaden the message
pattern from "Requested node type" to also match "type mismatch", so both
real-workspace messages are caught. Add unit tests for both shapes.

Co-authored-by: Isaac

Author: shreyas-goenka

libs/filer/workspace_files_client.go

@@ -11,6 +11,7 @@ import (
 	"net/http"
 	"path"
 	"slices"
+	"strings"
 	"time"
 
 	"github.com/databricks/databricks-sdk-go"
@@ -208,15 +209,30 @@ func (w *WorkspaceFilesClient) Write(ctx context.Context, name string, reader io
 		return w.Write(ctx, name, bytes.NewReader(body), sliceWithout(mode, CreateParentDirectories)...)
 	}
 
-	// Path already taken. /workspace/import returns 400 RESOURCE_ALREADY_EXISTS
-	// for sequential conflicts and 409 ALREADY_EXISTS under concurrent contention
-	// (observed in TestLock). Same-path collisions where the existing object is a
-	// different node type (e.g. NOTEBOOK at /a/foo, upload regular content to
-	// /a/foo) also surface here — verified against a real workspace, the server
-	// returns one of the two already-exists codes regardless of the type mismatch.
+	// Path already taken. /workspace/import returns this in three shapes,
+	// verified against a real workspace:
+	//
+	//  - 400 RESOURCE_ALREADY_EXISTS — sequential conflict, no overwrite flag.
+	//  - 409 ALREADY_EXISTS — concurrent contention (observed in TestLock).
+	//  - 400 INVALID_PARAMETER_VALUE with a "type mismatch" / "node type" message
+	//    — overwrite=true on a path where the existing object's node type differs
+	//    from the upload (e.g. NOTEBOOK at /a/foo, regular-content upload to
+	//    /a/foo with overwrite). The server refuses the overwrite even though the
+	//    caller asked for it; from the caller's perspective the path is occupied,
+	//    so we surface this as already-exists.
+	//
+	// Sources for the third bullet (`bundle deploy` issues with overwrite=true):
+	//   "Cannot overwrite the asset at X due to type mismatch (asked: ..., actual: ...)"
+	//   "Requested node type [...] is different from the existing node type [...]"
 	if errors.Is(err, apierr.ErrResourceAlreadyExists) || errors.Is(err, apierr.ErrAlreadyExists) {
 		return fileAlreadyExistsError{absPath}
 	}
+	if errors.Is(err, apierr.ErrInvalidParameterValue) {
+		var aerr *apierr.APIError
+		if errors.As(err, &aerr) && (strings.Contains(aerr.Message, "type mismatch") || strings.Contains(aerr.Message, "node type")) {
+			return fileAlreadyExistsError{absPath}
+		}
+	}
 
 	// Caller has read access but no write access.
 	if errors.Is(err, apierr.ErrPermissionDenied) {

libs/filer/workspace_files_client_test.go

@@ -187,20 +187,25 @@ func TestWorkspaceFilesClientWriteErrorMapping(t *testing.T) {
 			expectErrTarget: fileAlreadyExistsError{},
 		},
 		{
-			// Verified against a real workspace: when an existing NOTEBOOK at /a/foo
-			// (uploaded earlier as /a/foo.py with the source header) blocks a
-			// regular-content upload to /a/foo, the server returns 409 ALREADY_EXISTS
-			// rather than a node-type-specific code.
-			name: "409 ALREADY_EXISTS for cross-type collision maps to fileAlreadyExistsError",
+			name: "400 INVALID_PARAMETER_VALUE 'type mismatch' (overwrite=true) maps to fileAlreadyExistsError",
 			apiErr: &apierr.APIError{
-				StatusCode: http.StatusConflict,
-				ErrorCode:  "ALREADY_EXISTS",
-				Message:    "Node with name /dir/foo.py already exists. Please pass overwrite=true to update it.",
+				StatusCode: http.StatusBadRequest,
+				ErrorCode:  "INVALID_PARAMETER_VALUE",
+				Message:    "Cannot overwrite the asset at /dir/foo due to type mismatch (asked: FILE, actual: NOTEBOOK).",
+			},
+			expectErrTarget: fileAlreadyExistsError{},
+		},
+		{
+			name: "400 INVALID_PARAMETER_VALUE 'Requested node type' (overwrite=true) maps to fileAlreadyExistsError",
+			apiErr: &apierr.APIError{
+				StatusCode: http.StatusBadRequest,
+				ErrorCode:  "INVALID_PARAMETER_VALUE",
+				Message:    "Requested node type [FILE] is different from the existing node type [NOTEBOOK]",
 			},
 			expectErrTarget: fileAlreadyExistsError{},
 		},
 		{
-			name: "400 INVALID_PARAMETER_VALUE passes through",
+			name: "400 INVALID_PARAMETER_VALUE other message passes through",
 			apiErr: &apierr.APIError{
 				StatusCode: http.StatusBadRequest,
 				ErrorCode:  "INVALID_PARAMETER_VALUE",