Drop numeric-only validation from host URL workspace ID parsing

The new X-Databricks-Workspace-Id routing header accepts non-numeric
workspace identifiers (e.g. connection-style strings) in addition to
classic numeric workspace IDs; the server disambiguates. The URL parser
was rejecting any non-numeric value via strconv.ParseInt and silently
dropping it, which would block pasted URLs that carry one of the new
identifier shapes.

Remove the numeric validation from all three branches (?o=, ?w=,
?workspace_id=) in ExtractHostQueryParams and pass the raw value through.
Affects every caller of the helper:

- databricks auth login --host
- workspace.host in databricks.yml (via bundle/config/workspace.go)

Flip the existing "non-numeric is skipped" tests in hostparams_test.go
and host_env_test.go to "non-numeric is passed through". Add a positive
test case for a UUID-shaped connection-style identifier.

Author: Divyansh-db

libs/auth/host_env_test.go

@@ -53,9 +53,10 @@ func TestNormalizeDatabricksConfigFromEnv(t *testing.T) {
 			name: "no host env is a no-op",
 		},
 		{
-			name:     "non-numeric o is dropped, host trailing slash trimmed",
-			host:     "https://acme.databricks.net/?o=notanumber",
-			wantHost: "https://acme.databricks.net",
+			name:            "non-numeric o is passed through, host trailing slash trimmed",
+			host:            "https://acme.databricks.net/?o=notanumber",
+			wantHost:        "https://acme.databricks.net",
+			wantWorkspaceID: "notanumber",
 		},
 	}
 

libs/auth/hostparams.go

@@ -2,7 +2,6 @@ package auth
 
 import (
 	"net/url"
-	"strconv"
 	"strings"
 )
 
@@ -12,7 +11,10 @@ type HostParams struct {
 	Host string
 
 	// WorkspaceID extracted from ?o=, ?w=, or ?workspace_id=.
-	// Empty if not present or not numeric.
+	// Empty if not present. Any non-empty value is accepted as-is —
+	// X-Databricks-Workspace-Id supports both classic numeric workspace IDs
+	// and non-numeric connection-style identifiers, and the server
+	// disambiguates.
 	WorkspaceID string
 
 	// AccountID extracted from ?a= or ?account_id=.
@@ -26,9 +28,10 @@ type HostParams struct {
 // X-Databricks-Workspace-Id routing header; "o" is the legacy SPOG form and
 // stays accepted so URLs already in databricks.yml / shell history keep
 // working. When more than one is present, "o" wins to preserve the meaning
-// of existing URLs. Workspace IDs must be numeric; non-numeric values are
-// ignored. The returned Host has all query parameters and fragments
-// stripped.
+// of existing URLs. Workspace ID values are passed through unchanged — the
+// server-side header accepts both classic numeric IDs and non-numeric
+// connection-style identifiers. The returned Host has all query parameters
+// and fragments stripped.
 func ExtractHostQueryParams(host string) HostParams {
 	u, err := url.Parse(host)
 	if err != nil || u.RawQuery == "" {
@@ -39,17 +42,11 @@ func ExtractHostQueryParams(host string) HostParams {
 
 	var workspaceID string
 	if v := q.Get("o"); v != "" {
-		if _, err := strconv.ParseInt(v, 10, 64); err == nil {
-			workspaceID = v
-		}
+		workspaceID = v
 	} else if v := q.Get("w"); v != "" {
-		if _, err := strconv.ParseInt(v, 10, 64); err == nil {
-			workspaceID = v
-		}
+		workspaceID = v
 	} else if v := q.Get("workspace_id"); v != "" {
-		if _, err := strconv.ParseInt(v, 10, 64); err == nil {
-			workspaceID = v
-		}
+		workspaceID = v
 	}
 
 	var accountID string

libs/auth/hostparams_test.go

@@ -53,19 +53,24 @@ func TestExtractHostQueryParams(t *testing.T) {
 			want: HostParams{Host: "https://spog.example.com"},
 		},
 		{
-			name: "non-numeric ?o= is skipped",
+			name: "non-numeric ?o= is passed through",
 			host: "https://spog.example.com/?o=abc",
-			want: HostParams{Host: "https://spog.example.com"},
+			want: HostParams{Host: "https://spog.example.com", WorkspaceID: "abc"},
 		},
 		{
-			name: "non-numeric ?w= is skipped",
+			name: "non-numeric ?w= is passed through",
 			host: "https://spog.example.com/?w=abc",
-			want: HostParams{Host: "https://spog.example.com"},
+			want: HostParams{Host: "https://spog.example.com", WorkspaceID: "abc"},
 		},
 		{
-			name: "non-numeric ?workspace_id= is skipped",
+			name: "non-numeric ?workspace_id= is passed through",
 			host: "https://spog.example.com/?workspace_id=abc",
-			want: HostParams{Host: "https://spog.example.com"},
+			want: HostParams{Host: "https://spog.example.com", WorkspaceID: "abc"},
+		},
+		{
+			name: "connection-id-style ?w= value passed through",
+			host: "https://spog.example.com/?w=123e4567-e89b-12d3-a456-426614174000",
+			want: HostParams{Host: "https://spog.example.com", WorkspaceID: "123e4567-e89b-12d3-a456-426614174000"},
 		},
 		{
 			name: "invalid URL is left unchanged",