docsgen: drop the date stamp so docs regenerate deterministically (#5561)

`bundle/docsgen` stamped the current date into the `last_update`
frontmatter of `reference.md`/`resources.md`, so the generated docs
drifted on any day they weren't last regenerated. This removes the date
and adds `generate-docs` to the `generate-check` CI drift gate, since
the output is now reproducible per-PR.

This pull request and its description were written by Isaac.

Author: pietern

Taskfile.yml

@@ -757,8 +757,6 @@ tasks:
   #   - generate-schema-docs stamps x-since-version from `git tag`, so it churns
   #     after every release; jsonschema_for_docs.json is published separately to
   #     the docgen branch by .github/workflows/update-schema-docs.yml.
-  #   - generate-docs stamps the current date (time.Now in bundle/docsgen/main.go),
-  #     so reference.md/resources.md diff on any day they weren't last generated.
   # Keep this list in sync with `generate` when adding or removing generators.
   generate-check:
     desc: Run the reproducible generators (CI drift subset of `generate`)
@@ -767,6 +765,7 @@ tasks:
       - task: generate-refschema
       - task: generate-schema
       - task: generate-validation
+      - task: generate-docs
       - task: generate-direct
       - task: pydabs-codegen
 

bundle/docsgen/main.go

@@ -9,7 +9,6 @@ import (
 	"path"
 	"reflect"
 	"strings"
-	"time"
 
 	"github.com/databricks/cli/bundle/config"
 	"github.com/databricks/cli/bundle/internal/annotation"
@@ -46,7 +45,7 @@ func main() {
 		[]string{path.Join(annotationDir, "annotations.yml")},
 		path.Join(outputDir, rootFileName),
 		reflect.TypeFor[config.Root](),
-		fillTemplateVariables(string(rootHeader)),
+		string(rootHeader),
 	)
 	if err != nil {
 		log.Fatal(err)
@@ -59,7 +58,7 @@ func main() {
 		[]string{path.Join(annotationDir, "annotations_openapi.yml"), path.Join(annotationDir, "annotations_openapi_overrides.yml"), path.Join(annotationDir, "annotations.yml")},
 		path.Join(outputDir, resourcesFileName),
 		reflect.TypeFor[config.Resources](),
-		fillTemplateVariables(string(resourcesHeader)),
+		string(resourcesHeader),
 	)
 	if err != nil {
 		log.Fatal(err)
@@ -147,8 +146,3 @@ func assignAnnotation(s *jsonschema.Schema, a annotation.Descriptor) {
 		s.DoNotSuggest = true
 	}
 }
-
-func fillTemplateVariables(s string) string {
-	currentDate := time.Now().Format("2006-01-02")
-	return strings.ReplaceAll(s, "{{update_date}}", currentDate)
-}

bundle/docsgen/output/reference.md

@@ -1,7 +1,5 @@
 ---
 description: 'Configuration reference for databricks.yml'
-last_update:
-  date: {{update_date}}
 ---
 
 <!--DO NOT EDIT. This file is autogenerated with https://github.com/databricks/cli-->

bundle/docsgen/output/resources.md

@@ -1,7 +1,5 @@
 ---
 description: 'Learn about resources supported by Declarative Automation Bundles and how to configure them.'
-last_update:
-  date: {{update_date}}
 ---
 
 <!-- DO NOT EDIT. This file is autogenerated with https://github.com/databricks/cli -->