Skip to content

Commit 17773bf

Browse files
committed
Revert install-pythons trim
The test server (libs/testserver/jobs.go:531) maps a task's spark_version to a Python version (DBR 12 -> 3.9, 13 -> 3.10, 15 -> 3.11, >=16 -> 3.12) and calls `uv venv --python <ver>` at runtime. Acceptance tests using DBR 12.2 (integration_whl/wrapper*) or EnvMatrix on UV_PYTHON (templates/ default-python/integration_classic) therefore require those versions to be installed. Measured on the prior CI run: installing only 3.10 took ~6.7s on Windows, vs an estimated 30-60s for all five. Not worth breaking tests. The real Windows setup cost is Setup Go (2m49s cache restore), which is a different problem. Keeping the pydabs_1000_tasks invariant exclusion from the prior commit; linux/direct is now ~4m18s including reruns, under the <5 min target. Co-authored-by: Isaac
1 parent da8b775 commit 17773bf

3 files changed

Lines changed: 1 addition & 17 deletions

File tree

.github/actions/setup-build-environment/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ runs:
3838
version: "0.8.9"
3939

4040
- name: Install Python versions for tests
41-
run: make install-pythons-test
41+
run: make install-pythons
4242
shell: bash
4343

4444
- name: Install ruff (Python linter and formatter)

Makefile

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,14 +74,6 @@ checks: tidy ws links
7474
install-pythons:
7575
uv python install 3.9 3.10 3.11 3.12 3.13
7676

77-
# Subset of Python versions needed for unit + acceptance tests in CI.
78-
# 3.13 is already provided by actions/setup-python; 3.10 is the default for
79-
# acceptance bundle tests (see acceptance/bundle/test.toml). Integration and
80-
# scheduled runs still use `install-pythons` to cover the full matrix.
81-
.PHONY: install-pythons-test
82-
install-pythons-test:
83-
uv python install 3.10
84-
8577
.PHONY: test
8678
test: test-unit test-acc
8779

libs/patchwheel/patch_test.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -145,14 +145,6 @@ func TestPatchWheel(t *testing.T) {
145145
for _, py := range pythonVersions {
146146
t.Run(py, func(t *testing.T) {
147147
t.Parallel()
148-
149-
// Skip if the interpreter is not available via uv. CI only installs
150-
// a subset of versions to keep setup fast; the full matrix is
151-
// exercised in integration and scheduled runs.
152-
if err := exec.Command("uv", "python", "find", py).Run(); err != nil {
153-
t.Skipf("%s not available: %v", py, err)
154-
}
155-
156148
tempDir := t.TempDir()
157149

158150
projFiles := minimalPythonProject()

0 commit comments

Comments
 (0)