Wire instance_pools into resource-type enumerations and regenerate validation

Fixes CI failures from adding the instance_pools resource: update the
workspace-open supported-type lists, skip instance_pools (direct-only) in
the Terraform lifecycle test, extend the statemgmt StateToBundle tests for
full resource coverage, and regenerate the validation enum/required fields.

Author: radakam

bundle/deploy/terraform/lifecycle_test.go

@@ -18,6 +18,7 @@ func TestConvertLifecycleForAllResources(t *testing.T) {
 		"catalogs",
 		"external_locations",
 		"genie_spaces",
+		"instance_pools",
 		"job_runs",
 		"vector_search_endpoints",
 		"vector_search_indexes",

bundle/internal/validation/generated/enum_fields.go

@@ -57,6 +57,7 @@ func TestStateToBundleEmptyLocalResources(t *testing.T) {
 		"resources.postgres_synced_tables.test_postgres_synced_table":   {ID: "synced_tables/main.public.test_synced_table"},
 		"resources.vector_search_endpoints.test_vector_search_endpoint": {ID: "vs-endpoint-1"},
 		"resources.vector_search_indexes.test_vector_search_index":      {ID: "vs-index-1"},
+		"resources.instance_pools.test_instance_pool":                   {ID: "1"},
 	}
 	err := StateToBundle(t.Context(), state, &config)
 	assert.NoError(t, err)
@@ -149,6 +150,9 @@ func TestStateToBundleEmptyLocalResources(t *testing.T) {
 	assert.Equal(t, "vs-index-1", config.Resources.VectorSearchIndexes["test_vector_search_index"].ID)
 	assert.Equal(t, resources.ModifiedStatusDeleted, config.Resources.VectorSearchIndexes["test_vector_search_index"].ModifiedStatus)
 
+	assert.Equal(t, "1", config.Resources.InstancePools["test_instance_pool"].ID)
+	assert.Equal(t, resources.ModifiedStatusDeleted, config.Resources.InstancePools["test_instance_pool"].ModifiedStatus)
+
 	AssertFullResourceCoverage(t, &config)
 }
 
@@ -378,6 +382,13 @@ func TestStateToBundleEmptyRemoteResources(t *testing.T) {
 					},
 				},
 			},
+			InstancePools: map[string]*resources.InstancePool{
+				"test_instance_pool": {
+					CreateInstancePool: compute.CreateInstancePool{
+						InstancePoolName: "test_instance_pool",
+					},
+				},
+			},
 		},
 	}
 
@@ -477,6 +488,9 @@ func TestStateToBundleEmptyRemoteResources(t *testing.T) {
 	assert.Empty(t, config.Resources.VectorSearchIndexes["test_vector_search_index"].ID)
 	assert.Equal(t, resources.ModifiedStatusCreated, config.Resources.VectorSearchIndexes["test_vector_search_index"].ModifiedStatus)
 
+	assert.Empty(t, config.Resources.InstancePools["test_instance_pool"].ID)
+	assert.Equal(t, resources.ModifiedStatusCreated, config.Resources.InstancePools["test_instance_pool"].ModifiedStatus)
+
 	AssertFullResourceCoverage(t, &config)
 }
 
@@ -856,6 +870,18 @@ func TestStateToBundleModifiedResources(t *testing.T) {
 					},
 				},
 			},
+			InstancePools: map[string]*resources.InstancePool{
+				"test_instance_pool": {
+					CreateInstancePool: compute.CreateInstancePool{
+						InstancePoolName: "test_instance_pool",
+					},
+				},
+				"test_instance_pool_new": {
+					CreateInstancePool: compute.CreateInstancePool{
+						InstancePoolName: "test_instance_pool_new",
+					},
+				},
+			},
 		},
 	}
 	state := ExportedResourcesMap{
@@ -913,6 +939,8 @@ func TestStateToBundleModifiedResources(t *testing.T) {
 		"resources.vector_search_endpoints.test_vector_search_endpoint_old": {ID: "vs-endpoint-old"},
 		"resources.vector_search_indexes.test_vector_search_index":          {ID: "vs-index-1"},
 		"resources.vector_search_indexes.test_vector_search_index_old":      {ID: "vs-index-old"},
+		"resources.instance_pools.test_instance_pool":                       {ID: "1"},
+		"resources.instance_pools.test_instance_pool_old":                   {ID: "2"},
 	}
 	err := StateToBundle(t.Context(), state, &config)
 	assert.NoError(t, err)
@@ -1108,6 +1136,13 @@ func TestStateToBundleModifiedResources(t *testing.T) {
 	assert.Empty(t, config.Resources.VectorSearchIndexes["test_vector_search_index_new"].ID)
 	assert.Equal(t, resources.ModifiedStatusCreated, config.Resources.VectorSearchIndexes["test_vector_search_index_new"].ModifiedStatus)
 
+	assert.Equal(t, "1", config.Resources.InstancePools["test_instance_pool"].ID)
+	assert.Empty(t, config.Resources.InstancePools["test_instance_pool"].ModifiedStatus)
+	assert.Equal(t, "2", config.Resources.InstancePools["test_instance_pool_old"].ID)
+	assert.Equal(t, resources.ModifiedStatusDeleted, config.Resources.InstancePools["test_instance_pool_old"].ModifiedStatus)
+	assert.Empty(t, config.Resources.InstancePools["test_instance_pool_new"].ID)
+	assert.Equal(t, resources.ModifiedStatusCreated, config.Resources.InstancePools["test_instance_pool_new"].ModifiedStatus)
+
 	AssertFullResourceCoverage(t, &config)
 }
 

bundle/internal/validation/generated/required_fields.go

@@ -67,7 +67,7 @@ func TestBuildWorkspaceURLFragmentBasedResources(t *testing.T) {
 func TestBuildWorkspaceURLUnknownResourceType(t *testing.T) {
 	_, err := workspaceurls.BuildResourceURL("https://myworkspace.databricks.com", "unknown", "123", "")
 	assert.ErrorContains(t, err, "unknown resource type \"unknown\"")
-	assert.ErrorContains(t, err, "alerts, apps, catalogs, clusters, dashboards, database_catalogs, database_instances, experiments, genie_spaces, jobs, model_serving_endpoints, models, notebooks, pipelines, postgres_catalogs, postgres_synced_tables, quality_monitors, queries, registered_models, schemas, synced_database_tables, vector_search_endpoints, vector_search_indexes, volumes, warehouses")
+	assert.ErrorContains(t, err, "alerts, apps, catalogs, clusters, dashboards, database_catalogs, database_instances, experiments, genie_spaces, instance_pools, jobs, model_serving_endpoints, models, notebooks, pipelines, postgres_catalogs, postgres_synced_tables, quality_monitors, queries, registered_models, schemas, synced_database_tables, vector_search_endpoints, vector_search_indexes, volumes, warehouses")
 }
 
 func TestBuildWorkspaceURLHostWithTrailingSlash(t *testing.T) {
@@ -116,6 +116,7 @@ func TestWorkspaceOpenCommandCompletion(t *testing.T) {
 		"database_instances",
 		"experiments",
 		"genie_spaces",
+		"instance_pools",
 		"jobs",
 		"model_serving_endpoints",
 		"models",
@@ -146,7 +147,7 @@ func TestWorkspaceOpenCommandCompletionSecondArg(t *testing.T) {
 func TestWorkspaceOpenCommandHelpText(t *testing.T) {
 	cmd := newWorkspaceOpenCommand()
 
-	assert.Contains(t, cmd.Long, "Supported resource types: alerts, apps, catalogs, clusters, dashboards, database_catalogs, database_instances, experiments, genie_spaces, jobs, model_serving_endpoints, models, notebooks, pipelines, postgres_catalogs, postgres_synced_tables, quality_monitors, queries, registered_models, schemas, synced_database_tables, vector_search_endpoints, vector_search_indexes, volumes, warehouses.")
+	assert.Contains(t, cmd.Long, "Supported resource types: alerts, apps, catalogs, clusters, dashboards, database_catalogs, database_instances, experiments, genie_spaces, instance_pools, jobs, model_serving_endpoints, models, notebooks, pipelines, postgres_catalogs, postgres_synced_tables, quality_monitors, queries, registered_models, schemas, synced_database_tables, vector_search_endpoints, vector_search_indexes, volumes, warehouses.")
 	assert.Contains(t, cmd.Long, "databricks experimental open jobs 123456789")
 	assert.Contains(t, cmd.Long, "databricks experimental open notebooks /Users/user@example.com/my-notebook")
 	assert.Contains(t, cmd.Long, "databricks experimental open registered_models catalog.schema.my_model")