Commit 3dc5667
authored
Route sandbox CLI reviews through team:eng-sandbox (#5567)
## Summary
- The `eng-sandbox` GitHub team now exists
([databricks/teams/eng-sandbox](https://github.com/orgs/databricks/teams/eng-sandbox/members))
and is the right grain for sandbox CLI ownership.
- Add a static `team:eng-sandbox` roster to `.github/OWNERTEAMS` — the
maintainer-approval workflow can't resolve GitHub team membership via
`GITHUB_TOKEN`, so this file is the source of truth and has to mirror
the team's actual roster.
- Switch the `/cmd/sandbox/` and `/acceptance/cmd/sandbox/` rules in
`.github/OWNERS` from individual @-mentions to `team:eng-sandbox` so
reviews route through the team as it rotates.
## Test plan
- [x] `git diff` confirms only the two sandbox rules and the new roster
line change; every other section is untouched.
- [x] Roster matches the current GitHub team (verified via `gh api
/orgs/databricks/teams/eng-sandbox/members`).
- [ ] CI's maintainer-approval workflow resolves the new alias the same
way it resolves `team:platform` / `team:bundle` / `team:eng-apps-devex`.
This pull request and its description were written by Isaac.1 parent f157bd1 commit 3dc5667
2 files changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
| 25 | + | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| 18 | + | |
0 commit comments