Skip to content

Commit 3dc5667

Browse files
Route sandbox CLI reviews through team:eng-sandbox (#5567)
## Summary - The `eng-sandbox` GitHub team now exists ([databricks/teams/eng-sandbox](https://github.com/orgs/databricks/teams/eng-sandbox/members)) and is the right grain for sandbox CLI ownership. - Add a static `team:eng-sandbox` roster to `.github/OWNERTEAMS` — the maintainer-approval workflow can't resolve GitHub team membership via `GITHUB_TOKEN`, so this file is the source of truth and has to mirror the team's actual roster. - Switch the `/cmd/sandbox/` and `/acceptance/cmd/sandbox/` rules in `.github/OWNERS` from individual @-mentions to `team:eng-sandbox` so reviews route through the team as it rotates. ## Test plan - [x] `git diff` confirms only the two sandbox rules and the new roster line change; every other section is untouched. - [x] Roster matches the current GitHub team (verified via `gh api /orgs/databricks/teams/eng-sandbox/members`). - [ ] CI's maintainer-approval workflow resolves the new alias the same way it resolves `team:platform` / `team:bundle` / `team:eng-apps-devex`. This pull request and its description were written by Isaac.
1 parent f157bd1 commit 3dc5667

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

.github/OWNERS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
/acceptance/apps/ team:eng-apps-devex
2323

2424
# Sandbox
25-
/cmd/sandbox/ @pietern @akshaysingla-db @shuochen0311
26-
/acceptance/cmd/sandbox/ @pietern @akshaysingla-db @shuochen0311
25+
/cmd/sandbox/ team:eng-sandbox
26+
/acceptance/cmd/sandbox/ team:eng-sandbox
2727

2828
# Auth
2929
/cmd/auth/ team:platform

.github/OWNERTEAMS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@
1010
# bundle: https://github.com/orgs/databricks/teams/cli-maintainers
1111
# platform: https://github.com/orgs/databricks/teams/cli-platform
1212
# eng-apps-devex: https://github.com/orgs/databricks/teams/eng-apps-devex
13+
# eng-sandbox: https://github.com/orgs/databricks/teams/eng-sandbox
1314

1415
team:bundle @andrewnester @anton-107 @denik @janniklasrose @pietern @shreyas-goenka
1516
team:platform @simonfaltum @renaudhartert-db @hectorcast-db @parthban-db @tanmay-db @Divyansh-db @tejaskochar-db @mihaimitrea-db @chrisst @rauchy
1617
team:eng-apps-devex @fjakobs @Shridhad @atilafassina @keugenek @igrekun @pkosiec @MarioCadenas @pffigueiredo @ditadi @calvarjorge
18+
team:eng-sandbox @pietern @shuochen0311 @akshaysingla-db

0 commit comments

Comments
 (0)