Stop prefixing vector_search_endpoints names (#5209)

## Changes

- Stop applying `presets.name_prefix` (and the dev-mode `[dev <user>]`
rename) to `vector_search_endpoints` in
`bundle/config/mutator/resourcemutator/apply_presets.go`.
- Add `.agent/rules/name-prefix.md` capturing the principle (only prefix
display-name fields; never primary-key / object-id Names), scoped via
globs to `apply_presets.go`, `apply_target_mode*.go`, and
`bundle/direct/dresources/*.go`. Mirror as
`.cursor/rules/name-prefix.mdc`.
- Rename `TestAllNonUcResourcesAreRenamed` →
`TestAppropriateResourcesAreRenamed` (the carve-out list now includes a
non-UC resource), and refactor the long `resourceType ==` OR chain into
a `slices.Contains` over a named slice hoisted to the outer loop.
- `NEXT_CHANGELOG.md` entry under Bundles.

## Why

The vector search endpoint name is the API primary key — it's how GET,
UPDATE, and DELETE address the resource
(`bundle/direct/dresources/vector_search_endpoint.go`: `id :=
config.Name`; `recreate_on_changes` for the resource doesn't list `name`
only because there's no rename API at all, so a name change would
silently drift). Prefixing it changed which remote endpoint the bundle
pointed at, not just the label the user saw. The rule we want to encode
is broader (display-name fields can be prefixed; identity-bearing Names
cannot), but this PR only fixes the vector_search_endpoints case to keep
the change focused; mlflow Models, ModelServingEndpoints, etc. have the
same issue and are tracked for follow-up.

## Tests

- `go test ./bundle/config/mutator/resourcemutator/` passes;
`TestProcessTargetModeDevelopment` now asserts `vs_endpoint1` (not
`dev_lennart_vs_endpoint1`), and `TestAppropriateResourcesAreRenamed`
includes `*resources.VectorSearchEndpoint` in the carve-out list and
verifies the Name doesn't pick up a `dev` prefix.
- Confirmed locally that re-introducing the prefix loop in
`apply_presets.go` causes both the explicit assertion and the reflective
sweep to fail with clear diffs.
- `./task fmt`, `./task checks`, `./task lint`, `./task test` clean.

_This PR was written by Claude Code._

Author: janniklasrose

NEXT_CHANGELOG.md

@@ -8,6 +8,7 @@
 * Marked the default profile in the interactive pickers shown by `databricks auth switch`, `databricks auth logout`, `databricks auth token`, and `databricks auth login`, and moved it to the top of the list. `databricks auth login` and `databricks auth logout` now offer the same selectors as `databricks auth token` and `databricks auth switch` respectively.
 
 ### Bundles
+* Stop applying `presets.name_prefix` (and the dev-mode `[dev <user>]` rename) to `vector_search_endpoints` ([#5209](https://github.com/databricks/cli/pull/5209)).
 
 * Fix `bundle generate` job to preserve nested notebook directory structure ([#4596](https://github.com/databricks/cli/pull/4596))
 * Propagate authentication environment (including `DATABRICKS_CONFIG_PROFILE`) to the `experimental.python` subprocess so bundle validate/deploy no longer fails with a multi-profile host ambiguity error when several profiles in `~/.databrickscfg` share the same host.

bundle/config/mutator/resourcemutator/apply_presets.go

@@ -290,13 +290,9 @@ func (m *applyPresets) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnos
 		}
 	}
 
-	// Vector Search Endpoints: Prefix
-	for _, e := range r.VectorSearchEndpoints {
-		if e == nil {
-			continue
-		}
-		e.Name = normalizePrefix(prefix) + e.Name
-	}
+	// Vector Search Endpoints: no prefix. The endpoint name is the primary key
+	// (it's what GET/UPDATE/DELETE address by), so prefixing it would change
+	// the resource's identity rather than just its display name.
 
 	return diags
 }

bundle/config/mutator/resourcemutator/apply_target_mode_test.go

@@ -303,8 +303,8 @@ func TestProcessTargetModeDevelopment(t *testing.T) {
 	// Model serving endpoint 1
 	assert.Equal(t, "dev_lennart_servingendpoint1", b.Config.Resources.ModelServingEndpoints["servingendpoint1"].Name)
 
-	// Vector search endpoint 1
-	assert.Equal(t, "dev_lennart_vs_endpoint1", b.Config.Resources.VectorSearchEndpoints["vs_endpoint1"].Name)
+	// Vector search endpoint 1: name is the primary key, so it must not be prefixed.
+	assert.Equal(t, "vs_endpoint1", b.Config.Resources.VectorSearchEndpoints["vs_endpoint1"].Name)
 
 	// Registered model 1
 	assert.Equal(t, "dev_lennart_registeredmodel1", b.Config.Resources.RegisteredModels["registeredmodel1"].Name)
@@ -414,17 +414,33 @@ func TestAllResourcesMocked(t *testing.T) {
 	}
 }
 
-// Make sure that we at rename all non UC resources
-func TestAllNonUcResourcesAreRenamed(t *testing.T) {
+// TestAppropriateResourcesAreRenamed checks that every resource with a user-facing
+// Name field is renamed by dev-mode / presets.name_prefix, except for an
+// explicit carve-out list. The carve-out applies to resources whose Name is
+// the API primary key / object id (not a display name) — prefixing those
+// would change the resource's identity rather than its label.
+func TestAppropriateResourcesAreRenamed(t *testing.T) {
 	b := mockBundle(config.Development)
 
-	// UC resources should not have a prefix added to their name. Right now
-	// this list only contains the Volume, Catalog, and ExternalLocation resources since we have yet to remove
-	// prefixing support for UC schemas and registered models.
-	ucFields := []reflect.Type{
+	notRenamedFields := []reflect.Type{
 		reflect.TypeFor[*resources.Catalog](),
 		reflect.TypeFor[*resources.ExternalLocation](),
 		reflect.TypeFor[*resources.Volume](),
+		reflect.TypeFor[*resources.VectorSearchEndpoint](),
+	}
+
+	// Resources whose Name is server-generated or otherwise not a user-facing
+	// label, so the rename matrix doesn't apply. Reflection still finds a
+	// Name field on these via embedded SDK types, hence the explicit skip.
+	notUserNamed := []string{
+		"Apps",
+		"SecretScopes",
+		"DatabaseInstances",
+		"DatabaseCatalogs",
+		"SyncedDatabaseTables",
+		"PostgresProjects",
+		"PostgresBranches",
+		"PostgresEndpoints",
 	}
 
 	diags := bundle.ApplySeq(t.Context(), b, ApplyTargetMode(), ApplyPresets())
@@ -433,28 +449,24 @@ func TestAllNonUcResourcesAreRenamed(t *testing.T) {
 	resources := reflect.ValueOf(b.Config.Resources)
 	for i := range resources.NumField() {
 		field := resources.Field(i)
+		if field.Kind() != reflect.Map {
+			continue
+		}
+		resourceType := resources.Type().Field(i).Name
+		if slices.Contains(notUserNamed, resourceType) {
+			continue
+		}
+		for _, key := range field.MapKeys() {
+			resource := field.MapIndex(key)
+			nameField := resource.Elem().FieldByName("Name")
+			if !nameField.IsValid() || nameField.Kind() != reflect.String {
+				continue
+			}
 
-		if field.Kind() == reflect.Map {
-			for _, key := range field.MapKeys() {
-				resource := field.MapIndex(key)
-				nameField := resource.Elem().FieldByName("Name")
-				resourceType := resources.Type().Field(i).Name
-
-				// Skip resources that are not renamed (either because they don't have a user-facing Name field,
-				// or because their Name is server-generated rather than user-specified)
-				if resourceType == "Apps" || resourceType == "SecretScopes" || resourceType == "DatabaseInstances" || resourceType == "DatabaseCatalogs" || resourceType == "SyncedDatabaseTables" || resourceType == "PostgresProjects" || resourceType == "PostgresBranches" || resourceType == "PostgresEndpoints" {
-					continue
-				}
-
-				if !nameField.IsValid() || nameField.Kind() != reflect.String {
-					continue
-				}
-
-				if slices.Contains(ucFields, resource.Type()) {
-					assert.NotContains(t, nameField.String(), "dev", "process_target_mode should not rename '%s' in '%s'", key, resources.Type().Field(i).Name)
-				} else {
-					assert.Contains(t, nameField.String(), "dev", "process_target_mode should rename '%s' in '%s'", key, resources.Type().Field(i).Name)
-				}
+			if slices.Contains(notRenamedFields, resource.Type()) {
+				assert.NotContains(t, nameField.String(), "dev", "process_target_mode should not rename '%s' in '%s'", key, resourceType)
+			} else {
+				assert.Contains(t, nameField.String(), "dev", "process_target_mode should rename '%s' in '%s'", key, resourceType)
 			}
 		}
 	}