|
| 1 | +package testserver_test |
| 2 | + |
| 3 | +import ( |
| 4 | + "net/http" |
| 5 | + "net/http/httptest" |
| 6 | + "testing" |
| 7 | + |
| 8 | + "github.com/databricks/cli/libs/testserver" |
| 9 | + "github.com/stretchr/testify/assert" |
| 10 | +) |
| 11 | + |
| 12 | +type capture struct { |
| 13 | + handler string |
| 14 | + vars map[string]string |
| 15 | + notFound bool |
| 16 | +} |
| 17 | + |
| 18 | +func newRouter(t *testing.T) (*testserver.Router, *capture) { |
| 19 | + t.Helper() |
| 20 | + c := &capture{} |
| 21 | + r := testserver.NewRouter() |
| 22 | + r.Dispatch = func(w http.ResponseWriter, req *http.Request, h testserver.HandlerFunc, vars map[string]string) { |
| 23 | + c.vars = vars |
| 24 | + c.handler = h(testserver.Request{}).(string) |
| 25 | + } |
| 26 | + r.NotFound = func(w http.ResponseWriter, req *http.Request) { |
| 27 | + c.notFound = true |
| 28 | + } |
| 29 | + return r, c |
| 30 | +} |
| 31 | + |
| 32 | +func handlerNamed(name string) testserver.HandlerFunc { |
| 33 | + return func(req testserver.Request) any { return name } |
| 34 | +} |
| 35 | + |
| 36 | +func TestRouterExactMatch(t *testing.T) { |
| 37 | + r, c := newRouter(t) |
| 38 | + r.Handle("GET", "/foo", handlerNamed("foo-get")) |
| 39 | + |
| 40 | + r.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(http.MethodGet, "/foo", nil)) |
| 41 | + assert.Equal(t, "foo-get", c.handler) |
| 42 | + assert.Nil(t, c.vars) |
| 43 | +} |
| 44 | + |
| 45 | +func TestRouterWildcardMatch(t *testing.T) { |
| 46 | + r, c := newRouter(t) |
| 47 | + r.Handle("GET", "/items/{id}", handlerNamed("item-get")) |
| 48 | + |
| 49 | + r.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(http.MethodGet, "/items/42", nil)) |
| 50 | + assert.Equal(t, "item-get", c.handler) |
| 51 | + assert.Equal(t, map[string]string{"id": "42"}, c.vars) |
| 52 | +} |
| 53 | + |
| 54 | +func TestRouterCatchAllWildcard(t *testing.T) { |
| 55 | + r, c := newRouter(t) |
| 56 | + r.Handle("GET", "/files/{path...}", handlerNamed("files-get")) |
| 57 | + |
| 58 | + r.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(http.MethodGet, "/files/a/b/c", nil)) |
| 59 | + assert.Equal(t, "files-get", c.handler) |
| 60 | + assert.Equal(t, map[string]string{"path": "a/b/c"}, c.vars) |
| 61 | +} |
| 62 | + |
| 63 | +func TestRouterMultipleWildcards(t *testing.T) { |
| 64 | + r, c := newRouter(t) |
| 65 | + r.Handle("GET", "/items/{id}/files/{path...}", handlerNamed("nested")) |
| 66 | + |
| 67 | + r.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(http.MethodGet, "/items/42/files/a/b", nil)) |
| 68 | + assert.Equal(t, "nested", c.handler) |
| 69 | + assert.Equal(t, map[string]string{"id": "42", "path": "a/b"}, c.vars) |
| 70 | +} |
| 71 | + |
| 72 | +func TestRouterExactBeforeWildcard(t *testing.T) { |
| 73 | + r, c := newRouter(t) |
| 74 | + r.Handle("GET", "/foo", handlerNamed("exact")) |
| 75 | + r.Handle("HEAD", "/{path...}", handlerNamed("wildcard-head")) |
| 76 | + |
| 77 | + r.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(http.MethodGet, "/foo", nil)) |
| 78 | + assert.Equal(t, "exact", c.handler) |
| 79 | + |
| 80 | + c.handler = "" |
| 81 | + r.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(http.MethodHead, "/foo", nil)) |
| 82 | + assert.Equal(t, "wildcard-head", c.handler) |
| 83 | +} |
| 84 | + |
| 85 | +func TestRouterFirstRegistrationWins(t *testing.T) { |
| 86 | + t.Run("exact", func(t *testing.T) { |
| 87 | + r, c := newRouter(t) |
| 88 | + r.Handle("GET", "/foo", handlerNamed("first")) |
| 89 | + r.Handle("GET", "/foo", handlerNamed("second")) |
| 90 | + |
| 91 | + r.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(http.MethodGet, "/foo", nil)) |
| 92 | + assert.Equal(t, "first", c.handler) |
| 93 | + }) |
| 94 | + |
| 95 | + t.Run("wildcard", func(t *testing.T) { |
| 96 | + r, c := newRouter(t) |
| 97 | + r.Handle("GET", "/items/{id}", handlerNamed("first")) |
| 98 | + r.Handle("GET", "/items/{id}", handlerNamed("second")) |
| 99 | + |
| 100 | + r.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(http.MethodGet, "/items/42", nil)) |
| 101 | + assert.Equal(t, "first", c.handler) |
| 102 | + }) |
| 103 | +} |
| 104 | + |
| 105 | +func TestRouterNotFound(t *testing.T) { |
| 106 | + r, c := newRouter(t) |
| 107 | + r.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(http.MethodGet, "/missing", nil)) |
| 108 | + assert.True(t, c.notFound) |
| 109 | +} |
| 110 | + |
| 111 | +func TestRouterMethodNotAllowed(t *testing.T) { |
| 112 | + t.Run("exact", func(t *testing.T) { |
| 113 | + r, c := newRouter(t) |
| 114 | + r.Handle("GET", "/foo", handlerNamed("foo-get")) |
| 115 | + r.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(http.MethodPost, "/foo", nil)) |
| 116 | + assert.True(t, c.notFound, "wrong method on exact path should hit NotFound") |
| 117 | + assert.Empty(t, c.handler) |
| 118 | + }) |
| 119 | + |
| 120 | + t.Run("wildcard", func(t *testing.T) { |
| 121 | + r, c := newRouter(t) |
| 122 | + r.Handle("GET", "/items/{id}", handlerNamed("item-get")) |
| 123 | + r.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(http.MethodPost, "/items/42", nil)) |
| 124 | + assert.True(t, c.notFound, "wrong method on wildcard path should hit NotFound") |
| 125 | + assert.Empty(t, c.handler) |
| 126 | + }) |
| 127 | +} |
| 128 | + |
| 129 | +func TestRouterPercentEncodedSlash(t *testing.T) { |
| 130 | + r, c := newRouter(t) |
| 131 | + r.Handle("GET", "/files/{path...}", handlerNamed("files-get")) |
| 132 | + |
| 133 | + req := httptest.NewRequest(http.MethodGet, "/files/a%2Fb%2Fc", nil) |
| 134 | + r.ServeHTTP(httptest.NewRecorder(), req) |
| 135 | + assert.Equal(t, "files-get", c.handler) |
| 136 | + assert.Equal(t, "a/b/c", c.vars["path"]) |
| 137 | +} |
0 commit comments