Skip to content

Commit 46ced41

Browse files
Fix generate-direct race that ran apitypes generation twice (#5442)
## What - Remove dependency on `generate-direct-apitypes` from `generate-direct` target, keep only `generate-direct-resources` ## Why - `generate-direct-resources` already depends on `generate-direct-apitypes` which means apitypes is invoked twice concurrently ## Testing `./task generate-direct --dry --force` **Before** ``` [generate-openapi-json] wget ... && mv ... [generate-direct-apitypes] python3 generate_apitypes.py ... > apitypes.generated.yml [generate-openapi-json] wget ... && mv ... [generate-direct-apitypes] python3 generate_apitypes.py ... > apitypes.generated.yml [generate-direct-resources] uv run ... > resources.generated.yml ``` **After**: ``` [generate-openapi-json] wget ... && mv ... [generate-direct-apitypes] python3 generate_apitypes.py ... > apitypes.generated.yml [generate-direct-resources] uv run ... > resources.generated.yml ``` This pull request was written by Isaac.
1 parent 15cdda5 commit 46ced41

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

Taskfile.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,12 @@ tasks:
888888

889889
generate-direct:
890890
desc: Generate direct engine config (apitypes + resources)
891-
deps: ['generate-direct-apitypes', 'generate-direct-resources']
891+
# Depend only on generate-direct-resources; it already pulls in
892+
# generate-direct-apitypes transitively. Listing both as parallel deps
893+
# races: resources reads apitypes.generated.yml while the apitypes step's
894+
# `>` redirect is truncating it, silently dropping every resource whose
895+
# type comes from that file. Keep this chain linear.
896+
deps: ['generate-direct-resources']
892897

893898
generate-direct-apitypes:
894899
desc: Generate direct engine API types YAML

0 commit comments

Comments
 (0)