Commit 4adee6a
authored
Make --accelerator flag optional for ssh connect (#4947)
## Summary
- Remove the validation requiring `--accelerator` when using `--name`
(serverless mode) in `ssh connect`
- Add a proactive yellow warning at connect time when `--accelerator` is
omitted, informing users that serverless CPU is in private preview
- Add a reactive hint appended to the error message when the server
fails to start without an accelerator
## Test plan
- [x] Unit tests pass (`go test ./experimental/ssh/internal/client/`)
- [x] Build succeeds (`make build`)
- [x] Manual test: `./cli ssh connect --name test-conn --profile p`
shows warning and submits job without `--accelerator`
- [x] Existing `--accelerator` usage is unaffected (validation for valid
values still in place)
This pull request was AI-assisted by Isaac.1 parent 6045ca9 commit 4adee6a
2 files changed
Lines changed: 10 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
105 | 106 | | |
106 | 107 | | |
107 | 108 | | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | 109 | | |
112 | 110 | | |
113 | 111 | | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | 112 | | |
119 | 113 | | |
120 | 114 | | |
| |||
215 | 209 | | |
216 | 210 | | |
217 | 211 | | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
218 | 215 | | |
219 | 216 | | |
220 | 217 | | |
| |||
294 | 291 | | |
295 | 292 | | |
296 | 293 | | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
297 | 298 | | |
298 | 299 | | |
299 | 300 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | | - | |
| 39 | + | |
| 40 | + | |
42 | 41 | | |
43 | 42 | | |
44 | 43 | | |
| |||
0 commit comments