Skip to content

Commit 6167150

Browse files
committed
Post-rebase fixups: WaitAfterCreate signature, columns_to_sync now in remote
- WaitAfterCreate now takes id per #5258; the saved config.Name is the same as id, so the body is unchanged. - SDK v0.132.0 (#5237) returns delta_sync_index_spec.columns_to_sync (and the new columns_to_index field) on read. Drop the ignore_remote_changes rule and propagate both from remote in RemapState. Removes the drift/columns_to_sync acceptance test which was asserting the now-stale request-only behavior. Co-authored-by: Isaac
1 parent 5c1944d commit 6167150

12 files changed

Lines changed: 14 additions & 96 deletions

File tree

acceptance/bundle/refschema/out.fields.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3160,8 +3160,10 @@ resources.vector_search_endpoints.*.permissions[*].user_name string ALL
31603160
resources.vector_search_indexes.*.creator string REMOTE
31613161
resources.vector_search_indexes.*.delta_sync_index_spec *vectorsearch.DeltaSyncVectorIndexSpecRequest INPUT STATE
31623162
resources.vector_search_indexes.*.delta_sync_index_spec *vectorsearch.DeltaSyncVectorIndexSpecResponse REMOTE
3163-
resources.vector_search_indexes.*.delta_sync_index_spec.columns_to_sync []string INPUT STATE
3164-
resources.vector_search_indexes.*.delta_sync_index_spec.columns_to_sync[*] string INPUT STATE
3163+
resources.vector_search_indexes.*.delta_sync_index_spec.columns_to_index []string ALL
3164+
resources.vector_search_indexes.*.delta_sync_index_spec.columns_to_index[*] string ALL
3165+
resources.vector_search_indexes.*.delta_sync_index_spec.columns_to_sync []string ALL
3166+
resources.vector_search_indexes.*.delta_sync_index_spec.columns_to_sync[*] string ALL
31653167
resources.vector_search_indexes.*.delta_sync_index_spec.embedding_source_columns []vectorsearch.EmbeddingSourceColumn ALL
31663168
resources.vector_search_indexes.*.delta_sync_index_spec.embedding_source_columns[*] vectorsearch.EmbeddingSourceColumn ALL
31673169
resources.vector_search_indexes.*.delta_sync_index_spec.embedding_source_columns[*].embedding_model_endpoint_name string ALL

acceptance/bundle/resources/vector_search_indexes/drift/columns_to_sync/databricks.yml.tmpl

Lines changed: 0 additions & 23 deletions
This file was deleted.

acceptance/bundle/resources/vector_search_indexes/drift/columns_to_sync/out.test.toml

Lines changed: 0 additions & 4 deletions
This file was deleted.

acceptance/bundle/resources/vector_search_indexes/drift/columns_to_sync/output.txt

Lines changed: 0 additions & 34 deletions
This file was deleted.

acceptance/bundle/resources/vector_search_indexes/drift/columns_to_sync/script

Lines changed: 0 additions & 16 deletions
This file was deleted.

acceptance/bundle/resources/vector_search_indexes/drift/columns_to_sync/test.toml

Lines changed: 0 additions & 1 deletion
This file was deleted.

acceptance/bundle/resources/vector_search_indexes/recreate/with_endpoint/output.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ Plan: 2 to add, 0 to change, 2 to delete, 0 unchanged
102102
Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/deploy-vs-index-with-endpoint-[UNIQUE_NAME]/default/files...
103103

104104
This action will result in the deletion or recreation of the following Vector Search indexes.
105-
Delta Sync indexes re-run their embedding pipeline; Direct Access indexes lose all upserted vectors:
105+
Recreating a Delta Sync index re-runs the full embedding pipeline; recreating a Direct Access
106+
index drops all upserted vectors. Both can be expensive to rebuild:
106107
recreate resources.vector_search_indexes.my_index
107108
Deploying resources...
108109
Updating deployment state...
@@ -128,7 +129,7 @@ The following resources will be deleted:
128129
delete resources.vector_search_indexes.my_index
129130

130131
This action will result in the deletion of the following Vector Search indexes.
131-
For Delta Sync indexes, the source Delta table is preserved but the embedding pipeline is removed.
132+
For Delta Sync indexes, the source Delta Table is preserved but the embedding pipeline is removed.
132133
For Direct Access indexes, all upserted vectors are permanently lost:
133134
delete resources.vector_search_indexes.my_index
134135

acceptance/bundle/validate/presets_name_prefix/output.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"vector_search_endpoints": {
3434
"vs_endpoint": {
3535
"endpoint_type": "STANDARD",
36-
"name": "prefixvs_endpoint"
36+
"name": "vs_endpoint"
3737
}
3838
},
3939
"vector_search_indexes": {
@@ -88,7 +88,7 @@
8888
"vector_search_endpoints": {
8989
"vs_endpoint": {
9090
"endpoint_type": "STANDARD",
91-
"name": "prefix_vs_endpoint"
91+
"name": "vs_endpoint"
9292
}
9393
},
9494
"vector_search_indexes": {

acceptance/bundle/validate/presets_name_prefix_vs_index_endpoint/output.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"vector_search_endpoints": {
55
"vs_endpoint": {
66
"endpoint_type": "STANDARD",
7-
"name": "prefix_vs_endpoint"
7+
"name": "vs_endpoint"
88
}
99
},
1010
"vector_search_indexes": {

bundle/direct/dresources/resources.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,3 @@ resources:
536536
reason: immutable
537537
- field: direct_access_index_spec
538538
reason: immutable
539-
ignore_remote_changes:
540-
# columns_to_sync is request-only in the create spec and not returned by the read API.
541-
- field: delta_sync_index_spec.columns_to_sync
542-
reason: input_only

0 commit comments

Comments
 (0)