Clarify --features warning to suggest apps init without --template

Co-authored-by: Isaac

Author: pkosiec

cmd/apps/init.go

@@ -40,6 +40,13 @@ const (
 	appkitDefaultBranch  = "main"
 	appkitTemplateTagPfx = "template-v"
 	defaultProfile       = "DEFAULT"
+
+	// projectNamePlaceholder is the Go template variable used in template
+	// directory names to stand in for the user-provided project name.
+	projectNamePlaceholder = "{{.project_name}}"
+
+	// bundleConfigFile is the standard bundle configuration filename.
+	bundleConfigFile = "databricks.yml"
 )
 
 // normalizeVersion converts a version string to the template tag format "template-vX.X.X".
@@ -649,11 +656,11 @@ func isPreRenderedTemplate(templateDir string) bool {
 		return false
 	}
 	for _, e := range entries {
-		if e.IsDir() && strings.Contains(e.Name(), "{{.project_name}}") {
+		if e.IsDir() && strings.Contains(e.Name(), projectNamePlaceholder) {
 			return false
 		}
 	}
-	data, err := os.ReadFile(filepath.Join(templateDir, "databricks.yml"))
+	data, err := os.ReadFile(filepath.Join(templateDir, bundleConfigFile))
 	if err != nil {
 		// No databricks.yml — can't tell, assume normal template.
 		return false
@@ -682,17 +689,18 @@ func replaceProjectName(destDir, newName string) error {
 	}
 
 	// Update databricks.yml: bundle name and app name.
-	ymlPath := filepath.Join(destDir, "databricks.yml")
+	ymlPath := filepath.Join(destDir, bundleConfigFile)
 	data, err := os.ReadFile(ymlPath)
 	if err != nil {
-		return nil
+		// File may not exist for non-bundle templates; not an error.
+		return err //nolint:nilerr
 	}
 	content := string(data)
 
 	// Read the original bundle name so we can do a targeted replace of the
 	// app resource name that usually matches it.
 	origName := ""
-	for _, line := range strings.Split(content, "\n") {
+	for line := range strings.SplitSeq(content, "\n") {
 		trimmed := strings.TrimSpace(line)
 		if strings.HasPrefix(trimmed, "name:") && origName == "" {
 			origName = strings.TrimSpace(strings.TrimPrefix(trimmed, "name:"))
@@ -719,7 +727,7 @@ func findProjectSrcDir(templateDir string) string {
 		return templateDir
 	}
 	for _, e := range entries {
-		if e.IsDir() && strings.Contains(e.Name(), "{{.project_name}}") {
+		if e.IsDir() && strings.Contains(e.Name(), projectNamePlaceholder) {
 			return filepath.Join(templateDir, e.Name())
 		}
 	}
@@ -1172,7 +1180,7 @@ func runCreate(ctx context.Context, opts createOptions) error {
 			if !mandatory[p] {
 				log.Warnf(ctx, "Feature %q is not supported by this pre-rendered template and will be ignored."+
 					" Only .env will include its configuration."+
-					" To use all features dynamically, use the default AppKit template instead.", p)
+					" To use all features dynamically, run `databricks apps init` without --template.", p)
 			}
 		}
 	}
@@ -1532,7 +1540,7 @@ func copyTemplate(ctx context.Context, src, dest string, vars templateVars) (int
 		return 0, err
 	}
 	for _, e := range entries {
-		if e.IsDir() && strings.Contains(e.Name(), "{{.project_name}}") {
+		if e.IsDir() && strings.Contains(e.Name(), projectNamePlaceholder) {
 			srcProjectDir = filepath.Join(src, e.Name())
 			break
 		}