bundle/deploy/lock: rename CloseVersion to CompleteVersion

Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>

Author: shreyas-goenka

bundle/deploy/lock/lock.go

@@ -30,19 +30,19 @@ const (
 //
 // DMS semantics: CreateVersion atomically succeeds only if no other deployment
 // is in progress and the returned version is exactly +1 to the latest closed
-// version, providing serialized optimistic concurrency control. CloseVersion
+// version, providing serialized optimistic concurrency control. CompleteVersion
 // records the outcome.
 //
 // Workspace-filesystem semantics: CreateVersion acquires the workspace lock
-// file; CloseVersion releases it. The returned version number is a placeholder
+// file; CompleteVersion releases it. The returned version number is a placeholder
 // (the lock file does not track a monotonic counter today).
 type DeploymentManager interface {
 	// CreateVersion begins a new deployment for the given goal.
 	// Returns the version number assigned by the backend.
 	CreateVersion(ctx context.Context, goal Goal) (int64, error)
 
-	// CloseVersion finalizes the deployment version created by CreateVersion.
-	CloseVersion(ctx context.Context, version int64, status DeploymentStatus) error
+	// CompleteVersion finalizes the deployment version created by CreateVersion.
+	CompleteVersion(ctx context.Context, version int64, status DeploymentStatus) error
 }
 
 // NewDeploymentManager returns a DeploymentManager backed by the workspace

bundle/deploy/lock/workspace_filesystem.go

@@ -63,7 +63,7 @@ func (l *workspaceFilesystemLock) CreateVersion(ctx context.Context, goal Goal)
 	return 0, nil
 }
 
-func (l *workspaceFilesystemLock) CloseVersion(ctx context.Context, _ int64, _ DeploymentStatus) error {
+func (l *workspaceFilesystemLock) CompleteVersion(ctx context.Context, _ int64, _ DeploymentStatus) error {
 	// Return early if locking is disabled.
 	if !l.enabled {
 		log.Infof(ctx, "Skipping; locking is disabled")

bundle/phases/bind.go

@@ -35,7 +35,7 @@ func Bind(ctx context.Context, b *bundle.Bundle, opts *terraform.BindOptions, en
 		if logdiag.HasError(ctx) {
 			status = lock.DeploymentFailure
 		}
-		if err := dm.CloseVersion(ctx, version, status); err != nil {
+		if err := dm.CompleteVersion(ctx, version, status); err != nil {
 			logdiag.LogError(ctx, err)
 		}
 	}()
@@ -139,7 +139,7 @@ func Unbind(ctx context.Context, b *bundle.Bundle, bundleType, tfResourceType, r
 		if logdiag.HasError(ctx) {
 			status = lock.DeploymentFailure
 		}
-		if err := dm.CloseVersion(ctx, version, status); err != nil {
+		if err := dm.CompleteVersion(ctx, version, status); err != nil {
 			logdiag.LogError(ctx, err)
 		}
 	}()

bundle/phases/deploy.go

@@ -143,7 +143,7 @@ func Deploy(ctx context.Context, b *bundle.Bundle, outputHandler sync.OutputHand
 		if logdiag.HasError(ctx) {
 			status = lock.DeploymentFailure
 		}
-		if err := dm.CloseVersion(ctx, version, status); err != nil {
+		if err := dm.CompleteVersion(ctx, version, status); err != nil {
 			logdiag.LogError(ctx, err)
 		}
 	}()

bundle/phases/destroy.go

@@ -132,7 +132,7 @@ func Destroy(ctx context.Context, b *bundle.Bundle, engine engine.EngineType) {
 		if logdiag.HasError(ctx) {
 			status = lock.DeploymentFailure
 		}
-		if err := dm.CloseVersion(ctx, version, status); err != nil {
+		if err := dm.CompleteVersion(ctx, version, status); err != nil {
 			logdiag.LogError(ctx, err)
 		}
 	}()