Commit 79c6de3
authored
Mark vector search index index_subtype as backend_default (#5454)
## Changes
- Add `index_subtype` as `backend_default` for vector search indexes and
teach testserver to return a default value
- Add `--unique` to `print_requests.py` so tests can choose to collapse
subsequent GET requests (e.g. encountered during polling)
## Why
- Grants test was failing with recreate
```
acceptance_test.go:939: Diff:
--- bundle/resources/vector_search_indexes/grants/select/output.txt
+++
/tmp/TestAcceptbundleresourcesvector_search_indexesgrantsselect1239696916/001/output.txt
@@ -13,8 +13,11 @@
Deployment complete!
>>> [CLI] bundle plan
-Plan: 0 to add, 0 to change, 0 to delete, 3 unchanged
+recreate vector_search_indexes.my_index
+update vector_search_indexes.my_index.grants
+Plan: 1 to add, 1 to change, 1 to delete, 1 unchanged
+
>>> [CLI] grants get table main.default.vs_index_[UNIQUE_NAME]
{
"privilege_assignments": [
```
-
`bundle/resources/vector_search_indexes/recreate/embedding_dimension/out.requests.create.direct.json`
had an extra GET
```
---
bundle/resources/vector_search_indexes/recreate/embedding_dimension/out.requests.create.direct.json
+++
/tmp/TestAcceptbundleresourcesvector_search_indexesrecreateembed3063347120/001/out.requests.create.direct.json
@@ -21,3 +21,555 @@
"method": "GET",
"path":
"/api/2.0/vector-search/indexes/main.default.vs_index_[UNIQUE_NAME]"
}
+{
+ "method": "GET",
+ "path":
"/api/2.0/vector-search/indexes/main.default.vs_index_[UNIQUE_NAME]"
+}
```
## Tests
Reverted the `resources.yml` change and reran `grants/select`:
```
>>> [CLI] bundle plan
-Plan: 0 to add, 0 to change, 0 to delete, 3 unchanged
+recreate vector_search_indexes.my_index
+update vector_search_indexes.my_index.grants
+
+Plan: 1 to add, 1 to change, 1 to delete, 1 unchanged
```1 parent 5dcec26 commit 79c6de3
7 files changed
Lines changed: 55 additions & 5 deletions
File tree
- acceptance
- bin
- bundle/resources/vector_search_indexes/recreate
- embedding_dimension
- with_endpoint
- bundle/direct/dresources
- libs/testserver
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
59 | 78 | | |
60 | 79 | | |
61 | 80 | | |
| |||
104 | 123 | | |
105 | 124 | | |
106 | 125 | | |
107 | | - | |
| 126 | + | |
108 | 127 | | |
109 | 128 | | |
110 | 129 | | |
| |||
145 | 164 | | |
146 | 165 | | |
147 | 166 | | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
148 | 174 | | |
149 | 175 | | |
150 | 176 | | |
| |||
155 | 181 | | |
156 | 182 | | |
157 | 183 | | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
158 | 189 | | |
159 | 190 | | |
160 | 191 | | |
| |||
175 | 206 | | |
176 | 207 | | |
177 | 208 | | |
178 | | - | |
| 209 | + | |
179 | 210 | | |
180 | 211 | | |
181 | 212 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
16 | 18 | | |
17 | 19 | | |
18 | 20 | | |
| |||
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| 76 | + | |
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
| |||
86 | 87 | | |
87 | 88 | | |
88 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
89 | 95 | | |
90 | 96 | | |
91 | 97 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
608 | 608 | | |
609 | 609 | | |
610 | 610 | | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
67 | 73 | | |
68 | 74 | | |
69 | 75 | | |
70 | 76 | | |
71 | 77 | | |
| 78 | + | |
72 | 79 | | |
73 | 80 | | |
74 | 81 | | |
| |||
0 commit comments