lakebox: integrate as a 'databricks lakebox' subcommand

Wire the cmd/lakebox tree from #4930 into the main CLI:

 - cmd/cmd.go registers lakebox.New() under the 'development' command
   group alongside bundle and sync.
 - cmd/fuzz_panic_test.go adds 'lakebox' to manualRoots so TestCountFuzz
   doesn't fuzz hand-written commands as if they were auto-generated.
 - cmd/lakebox tree: the original PR's standalone-CLI scaffolding is
   adapted for subcommand use — drop the auth-login hijacking and its
   helper exports, drop the 'last_profile' state field that only mattered
   when lakebox owned the whole CLI, switch PreRunE to root.MustWorkspaceClient
   directly, and update help text from 'lakebox foo' to
   'databricks lakebox foo' throughout.

Also conforms cmd/lakebox to project lint rules: env.UserHomeDir(ctx)
in place of os.UserHomeDir, errors.Is(err, fs.ErrNotExist) instead of
os.IsNotExist, atomic.Bool over sync.Once in the spinner gate, errors.New
for static error strings.

Co-authored-by: Isaac

Author: pietern

cmd/cmd.go

@@ -17,6 +17,7 @@ import (
 	"github.com/databricks/cli/cmd/experimental"
 	"github.com/databricks/cli/cmd/fs"
 	"github.com/databricks/cli/cmd/labs"
+	"github.com/databricks/cli/cmd/lakebox"
 	"github.com/databricks/cli/cmd/pipelines"
 	"github.com/databricks/cli/cmd/root"
 	"github.com/databricks/cli/cmd/selftest"
@@ -103,6 +104,7 @@ func New(ctx context.Context) *cobra.Command {
 	cli.AddCommand(configure.New())
 	cli.AddCommand(fs.New())
 	cli.AddCommand(labs.New(ctx))
+	cli.AddCommand(lakebox.New())
 	cli.AddCommand(sync.New())
 	cli.AddCommand(version.New())
 	cli.AddCommand(selftest.New())

cmd/fuzz_panic_test.go

@@ -208,6 +208,7 @@ func isAutoGenerated(leaf leafCommand) bool {
 		"configure":    true,
 		"experimental": true,
 		"labs":         true,
+		"lakebox":      true,
 		"pipelines":    true,
 		"psql":         true,
 		"selftest":     true,

cmd/lakebox/config.go

@@ -1,9 +1,11 @@
 package lakebox
 
 import (
+	"errors"
 	"fmt"
 	"time"
 
+	"github.com/databricks/cli/cmd/root"
 	"github.com/databricks/cli/libs/cmdctx"
 	"github.com/spf13/cobra"
 )
@@ -39,17 +41,17 @@ Two knobs are independent — pass either or both:
                               this is on. Setting --idle-timeout to a
                               non-zero value in a later call clears
                               --no-autostop automatically. Sandbox still
-                              stops on explicit 'lakebox delete'.
+                              stops on explicit 'databricks lakebox delete'.
 
 Examples:
-  lakebox config happy-panda-1234 --idle-timeout 15m
-  lakebox config happy-panda-1234 --idle-timeout 1h30m
-  lakebox config happy-panda-1234 --idle-timeout 0           # clear, use default
-  lakebox config happy-panda-1234 --no-autostop                  # never auto-stop
-  lakebox config happy-panda-1234 --no-autostop=false            # back to timeout path
-  lakebox config happy-panda-1234 --idle-timeout 30m --no-autostop=false`,
+  databricks lakebox config happy-panda-1234 --idle-timeout 15m
+  databricks lakebox config happy-panda-1234 --idle-timeout 1h30m
+  databricks lakebox config happy-panda-1234 --idle-timeout 0           # clear, use default
+  databricks lakebox config happy-panda-1234 --no-autostop                  # never auto-stop
+  databricks lakebox config happy-panda-1234 --no-autostop=false            # back to timeout path
+  databricks lakebox config happy-panda-1234 --idle-timeout 30m --no-autostop=false`,
 		Args:    cobra.ExactArgs(1),
-		PreRunE: mustWorkspaceClient,
+		PreRunE: root.MustWorkspaceClient,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
 			w := cmdctx.WorkspaceClient(ctx)
@@ -76,7 +78,7 @@ Examples:
 			}
 
 			if idleSecs == nil && noAutostop == nil {
-				return fmt.Errorf("nothing to update — pass --idle-timeout and/or --no-autostop")
+				return errors.New("nothing to update — pass --idle-timeout and/or --no-autostop")
 			}
 
 			updated, err := api.update(ctx, id, idleSecs, noAutostop)

cmd/lakebox/create.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"os"
 
+	"github.com/databricks/cli/cmd/root"
 	"github.com/databricks/cli/libs/cmdctx"
 	"github.com/spf13/cobra"
 )
@@ -20,8 +21,8 @@ Creates a new personal development environment backed by a microVM.
 Blocks until the lakebox is running and prints the lakebox ID.
 
 Example:
-  lakebox create`,
-		PreRunE: mustWorkspaceClient,
+  databricks lakebox create`,
+		PreRunE: root.MustWorkspaceClient,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
 			w := cmdctx.WorkspaceClient(ctx)
@@ -52,15 +53,15 @@ Example:
 				profile = w.Config.Host
 			}
 
-			currentDefault := getDefault(profile)
+			currentDefault := getDefault(ctx, profile)
 			shouldSetDefault := currentDefault == ""
 			if !shouldSetDefault && currentDefault != "" {
 				if _, err := api.get(ctx, currentDefault); err != nil {
 					shouldSetDefault = true
 				}
 			}
 			if shouldSetDefault {
-				if err := setDefault(profile, result.SandboxID); err != nil {
+				if err := setDefault(ctx, profile, result.SandboxID); err != nil {
 					warn(stderr, fmt.Sprintf("Could not save default: %v", err))
 				} else {
 					field(stderr, "default", result.SandboxID)

cmd/lakebox/default.go

@@ -3,6 +3,7 @@ package lakebox
 import (
 	"fmt"
 
+	"github.com/databricks/cli/cmd/root"
 	"github.com/databricks/cli/libs/cmdctx"
 	"github.com/spf13/cobra"
 )
@@ -18,16 +19,17 @@ The default is stored locally in ~/.databricks/lakebox.json per profile.
 Example:
   databricks lakebox set-default happy-panda-1234`,
 		Args:    cobra.ExactArgs(1),
-		PreRunE: mustWorkspaceClient,
+		PreRunE: root.MustWorkspaceClient,
 		RunE: func(cmd *cobra.Command, args []string) error {
-			w := cmdctx.WorkspaceClient(cmd.Context())
+			ctx := cmd.Context()
+			w := cmdctx.WorkspaceClient(ctx)
 			profile := w.Config.Profile
 			if profile == "" {
 				profile = w.Config.Host
 			}
 
 			lakeboxID := args[0]
-			if err := setDefault(profile, lakeboxID); err != nil {
+			if err := setDefault(ctx, profile, lakeboxID); err != nil {
 				return fmt.Errorf("failed to set default: %w", err)
 			}
 			fmt.Fprintf(cmd.OutOrStdout(), "Default lakebox set to: %s\n", lakeboxID)

cmd/lakebox/delete.go

@@ -3,6 +3,7 @@ package lakebox
 import (
 	"fmt"
 
+	"github.com/databricks/cli/cmd/root"
 	"github.com/databricks/cli/libs/cmdctx"
 	"github.com/spf13/cobra"
 )
@@ -16,32 +17,32 @@ func newDeleteCommand() *cobra.Command {
 Permanently terminates and removes the specified lakebox.
 
 Example:
-  lakebox delete happy-panda-1234`,
+  databricks lakebox delete happy-panda-1234`,
 		Args:    cobra.ExactArgs(1),
-		PreRunE: mustWorkspaceClient,
+		PreRunE: root.MustWorkspaceClient,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
 			w := cmdctx.WorkspaceClient(ctx)
 			api := newLakeboxAPI(w)
 			stderr := cmd.ErrOrStderr()
 
 			lakeboxID := args[0]
-			s := spin(stderr, fmt.Sprintf("Removing %s…", lakeboxID))
+			s := spin(stderr, "Removing "+lakeboxID+"…")
 
 			if err := api.delete(ctx, lakeboxID); err != nil {
-				s.fail(fmt.Sprintf("Failed to delete %s", lakeboxID))
+				s.fail("Failed to delete " + lakeboxID)
 				return fmt.Errorf("failed to delete lakebox %s: %w", lakeboxID, err)
 			}
 
 			profile := w.Config.Profile
 			if profile == "" {
 				profile = w.Config.Host
 			}
-			if getDefault(profile) == lakeboxID {
-				_ = clearDefault(profile)
-				s.ok(fmt.Sprintf("Removed %s %s", bold(lakeboxID), dim("(default cleared)")))
+			if getDefault(ctx, profile) == lakeboxID {
+				_ = clearDefault(ctx, profile)
+				s.ok("Removed " + bold(lakeboxID) + " " + dim("(default cleared)"))
 			} else {
-				s.ok(fmt.Sprintf("Removed %s", bold(lakeboxID)))
+				s.ok("Removed " + bold(lakeboxID))
 			}
 			return nil
 		},

cmd/lakebox/lakebox.go

@@ -1,34 +1,32 @@
 package lakebox
 
 import (
-	"github.com/databricks/cli/cmd/root"
 	"github.com/spf13/cobra"
 )
 
 func New() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:   "lakebox",
-		Short: "Manage Databricks Lakebox environments",
+		Use:     "lakebox",
+		Short:   "Manage Databricks Lakebox environments",
+		GroupID: "development",
 		Long: `Manage Databricks Lakebox environments.
 
 Lakebox provides SSH-accessible development environments backed by
 microVM isolation. Each lakebox is a personal sandbox with pre-installed
 tooling (Python, Node.js, Rust, Databricks CLI) and persistent storage.
 
 Getting started:
-  lakebox auth login --host https://...   # authenticate to Databricks workspace and lakebox service
-  lakebox ssh                             # SSH to your default lakebox
+  databricks auth login --host https://...   # authenticate to a Databricks workspace
+  databricks lakebox register                # generate and register an SSH key
+  databricks lakebox ssh                     # SSH to your default lakebox
 
 Common workflows:
-  lakebox ssh                             # SSH to your default lakebox
-  lakebox ssh my-project                  # SSH to a named lakebox
-  lakebox list                            # list your lakeboxes
-  lakebox create                          # create a new lakebox
-  lakebox delete my-project               # delete a lakebox
-  lakebox status my-project               # show lakebox status
-
-The CLI manages your ~/.ssh/config so you can also connect directly:
-  ssh my-project                          # after 'lakebox ssh'
+  databricks lakebox ssh                     # SSH to your default lakebox
+  databricks lakebox ssh my-project          # SSH to a named lakebox
+  databricks lakebox list                    # list your lakeboxes
+  databricks lakebox create                  # create a new lakebox
+  databricks lakebox delete my-project       # delete a lakebox
+  databricks lakebox status my-project       # show lakebox status
 `,
 	}
 
@@ -43,15 +41,3 @@ The CLI manages your ~/.ssh/config so you can also connect directly:
 
 	return cmd
 }
-
-// mustWorkspaceClient applies the saved last-login profile when the user
-// hasn't explicitly set --profile, then delegates to root.MustWorkspaceClient.
-func mustWorkspaceClient(cmd *cobra.Command, args []string) error {
-	profileFlag := cmd.Flag("profile")
-	if profileFlag != nil && !profileFlag.Changed {
-		if last := GetLastProfile(); last != "" {
-			_ = profileFlag.Value.Set(last)
-		}
-	}
-	return root.MustWorkspaceClient(cmd, args)
-}

cmd/lakebox/list.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"strings"
 
+	"github.com/databricks/cli/cmd/root"
 	"github.com/databricks/cli/libs/cmdctx"
 	"github.com/spf13/cobra"
 )
@@ -21,9 +22,9 @@ Shows all lakeboxes associated with your account, including their
 current status and ID.
 
 Example:
-  lakebox list
-  lakebox list --json`,
-		PreRunE: mustWorkspaceClient,
+  databricks lakebox list
+  databricks lakebox list --json`,
+		PreRunE: root.MustWorkspaceClient,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
 			w := cmdctx.WorkspaceClient(ctx)
@@ -49,7 +50,7 @@ Example:
 			if profile == "" {
 				profile = w.Config.Host
 			}
-			defaultID := getDefault(profile)
+			defaultID := getDefault(ctx, profile)
 
 			out := cmd.OutOrStdout()
 
@@ -80,21 +81,12 @@ Example:
 					def = accent("*")
 				}
 				// Pad ID manually to avoid ANSI codes breaking alignment.
-				idPad := col - len(id)
-				if idPad < 0 {
-					idPad = 0
-				}
+				idPad := max(col-len(id), 0)
 				st := status(e.Status)
 				// Pad status to 10 visible chars.
-				stPad := 10 - len(e.Status)
-				if stPad < 0 {
-					stPad = 0
-				}
+				stPad := max(10-len(e.Status), 0)
 				as := e.autoStopLabel()
-				asPad := autostopCol - len(as)
-				if asPad < 0 {
-					asPad = 0
-				}
+				asPad := max(autostopCol-len(as), 0)
 				idStr := bold(id)
 				if strings.EqualFold(e.Status, "running") {
 					idStr = cyan + bo + id + rs