bundle/phases: surface Release errors via logdiag (restore pre-refactor semantics)

The original release.go mutator returned diag.FromErr on unlock failure,
which surfaced as an error diagnostic to the user. The defer pattern
introduced in #5314 dropped it to log.Warnf — a silent demotion that
would hide a stuck lock from the user (who normally has to recover with
--force-lock).

Switch the defer to logdiag.LogError so the unlock failure shows up as a
proper diagnostic, matching the pre-refactor behavior. The deploy/destroy/
bind/unbind phases all share the same fix.

Co-authored-by: Isaac

Author: shreyas-goenka

bundle/phases/bind.go

@@ -35,7 +35,7 @@ func Bind(ctx context.Context, b *bundle.Bundle, opts *terraform.BindOptions, en
 			status = lock.DeploymentFailure
 		}
 		if err := dl.Release(ctx, status); err != nil {
-			log.Warnf(ctx, "Failed to release deployment lock: %v", err)
+			logdiag.LogError(ctx, err)
 		}
 	}()
 
@@ -138,7 +138,7 @@ func Unbind(ctx context.Context, b *bundle.Bundle, bundleType, tfResourceType, r
 			status = lock.DeploymentFailure
 		}
 		if err := dl.Release(ctx, status); err != nil {
-			log.Warnf(ctx, "Failed to release deployment lock: %v", err)
+			logdiag.LogError(ctx, err)
 		}
 	}()
 

bundle/phases/deploy.go

@@ -144,7 +144,7 @@ func Deploy(ctx context.Context, b *bundle.Bundle, outputHandler sync.OutputHand
 			status = lock.DeploymentFailure
 		}
 		if err := dl.Release(ctx, status); err != nil {
-			log.Warnf(ctx, "Failed to release deployment lock: %v", err)
+			logdiag.LogError(ctx, err)
 		}
 	}()
 

bundle/phases/destroy.go

@@ -132,7 +132,7 @@ func Destroy(ctx context.Context, b *bundle.Bundle, engine engine.EngineType) {
 			status = lock.DeploymentFailure
 		}
 		if err := dl.Release(ctx, status); err != nil {
-			log.Warnf(ctx, "Failed to release deployment lock: %v", err)
+			logdiag.LogError(ctx, err)
 		}
 	}()