Drop testifylint empty/len/equal-values exceptions (#5329)

Removes three `testifylint.disable` entries from `.golangci.yaml`:

- `empty` — flagged ~171 sites of `assert.Equal(t, "", x)` /
`assert.Len(t, x, 0)` that should be `assert.Empty`.
- `len` — flagged ~11 sites of `assert.Equal(t, N, len(x))` that should
be `assert.Len`.
- `equal-values` — flagged 7 sites of `assert.EqualValues` where types
already match.

All 189 sites were fixed mechanically by `golangci-lint --fix`; no hand
edits, and `./task test` passes. The remaining two disables
(`require-error`, `encoded-compare`) are untouched.

Author: pietern

.golangci.yaml

@@ -156,9 +156,6 @@ linters:
       enable-all: true
       disable:
         - require-error # good check, but we have too many assert.(No)?Errorf? so excluding for now
-        - empty
-        - len
-        - equal-values
         - encoded-compare # Always replaces Equal() with JSONEq, but sometimes exact string match is wanted for JSON
     exhaustive:
       default-signifies-exhaustive: true

bundle/config/mutator/python/python_mutator_test.go

@@ -158,7 +158,7 @@ workspace: { current_user: { userName: test }}`)
 	assert.Equal(t, int64(2), b.Metrics.PythonAddedResourcesCount)
 	assert.Equal(t, int64(0), b.Metrics.PythonUpdatedResourcesCount)
 
-	assert.Equal(t, 1, len(diags))
+	assert.Len(t, diags, 1)
 	assert.Equal(t, "job doesn't have any tasks", diags[0].Summary)
 	assert.Equal(t, []dyn.Location{
 		{

bundle/config/mutator/resourcemutator/capture_uc_dependencies_test.go

@@ -220,7 +220,7 @@ func TestCaptureUCDependenciesQualityMonitorEdgeCases(t *testing.T) {
 
 	assert.Equal(t, "${resources.catalogs.my_catalog.name}.other", b.Config.Resources.QualityMonitors["catalog_only"].OutputSchemaName)
 	assert.Equal(t, "other.other", b.Config.Resources.QualityMonitors["no_match"].OutputSchemaName)
-	assert.Equal(t, "", b.Config.Resources.QualityMonitors["empty"].OutputSchemaName)
+	assert.Empty(t, b.Config.Resources.QualityMonitors["empty"].OutputSchemaName)
 	assert.Equal(t, "nodot", b.Config.Resources.QualityMonitors["no_dot"].OutputSchemaName)
 	assert.Nil(t, b.Config.Resources.QualityMonitors["nil_monitor"])
 }

bundle/config/mutator/resourcemutator/fix_permissions_test.go

@@ -23,7 +23,7 @@ func TestGetMaxLevel(t *testing.T) {
 	assert.Equal(t, "CAN_MANAGE", resources.GetMaxLevel("CAN_MANAGE", "CAN_MANAGE"))
 	assert.Equal(t, "CAN_READ", resources.GetMaxLevel("CAN_READ", ""))
 	assert.Equal(t, "CAN_READ", resources.GetMaxLevel("", "CAN_READ"))
-	assert.Equal(t, "", resources.GetMaxLevel("", ""))
+	assert.Empty(t, resources.GetMaxLevel("", ""))
 
 	assert.Equal(t, "UNKNOWN_B", resources.GetMaxLevel("UNKNOWN_A", "UNKNOWN_B"))
 	assert.Equal(t, "UNKNOWN_B", resources.GetMaxLevel("UNKNOWN_B", "UNKNOWN_A"))

bundle/config/mutator/resourcemutator/secret_scope_fixups_test.go

@@ -245,9 +245,9 @@ func TestAddManageForCurrentUser(t *testing.T) {
 			assert.ElementsMatch(t, tt.expectedPerms, scope.Permissions)
 
 			if tt.shouldAddNewPerm {
-				assert.Equal(t, initialCount+1, len(scope.Permissions))
+				assert.Len(t, scope.Permissions, initialCount+1)
 			} else {
-				assert.Equal(t, initialCount, len(scope.Permissions))
+				assert.Len(t, scope.Permissions, initialCount)
 			}
 		})
 	}

bundle/deploy/terraform/init_test.go

@@ -279,7 +279,7 @@ func TestInheritOIDCTokenEnv(t *testing.T) {
 	err := inheritEnvVars(ctx, env)
 	require.NoError(t, err)
 	assert.Equal(t, "foobar", env["DATABRICKS_OIDC_TOKEN"])
-	assert.Equal(t, "", env["DATABRICKS_OIDC_TOKEN_ENV"])
+	assert.Empty(t, env["DATABRICKS_OIDC_TOKEN_ENV"])
 }
 
 func TestInheritAzureDevOpsSystemVariablesIndividual(t *testing.T) {

bundle/deploy/terraform/tfdyn/convert_secret_scope_test.go

@@ -94,7 +94,7 @@ func TestConvertSecretScopeNoPermissions(t *testing.T) {
 	require.NoError(t, err)
 
 	// No ACLs should be created
-	assert.Len(t, out.SecretAcl, 0)
+	assert.Empty(t, out.SecretAcl)
 
 	// But the scope should still be created
 	assert.Contains(t, out.SecretScope, "no_permissions_scope")

bundle/direct/dstate/state_test.go

@@ -71,6 +71,6 @@ func TestDeleteState(t *testing.T) {
 	var db3 DeploymentState
 	require.NoError(t, db3.Open(t.Context(), path, WithRecovery(false), WithWrite(false)))
 	assert.Equal(t, 2, db3.Data.Serial)
-	assert.Equal(t, "", db3.GetResourceID("jobs.my_job"))
+	assert.Empty(t, db3.GetResourceID("jobs.my_job"))
 	mustFinalize(t, &db3)
 }

bundle/env/env_test.go

@@ -19,7 +19,7 @@ func TestGetWithRealEnvSingleVariable(t *testing.T) {
 	// Not set.
 	v, ok = get(t.Context(), []string{"v2"})
 	require.False(t, ok)
-	assert.Equal(t, "", v)
+	assert.Empty(t, v)
 }
 
 func TestGetWithRealEnvMultipleVariables(t *testing.T) {
@@ -39,5 +39,5 @@ func TestGetWithRealEnvMultipleVariables(t *testing.T) {
 	// Not set.
 	v, ok := get(t.Context(), []string{"v2", "v3", "v4"})
 	require.False(t, ok)
-	assert.Equal(t, "", v)
+	assert.Empty(t, v)
 }

bundle/env/root_test.go

@@ -37,6 +37,6 @@ func TestRoot(t *testing.T) {
 	t.Run("not set", func(t *testing.T) {
 		root, ok := Root(ctx)
 		assert.False(t, ok)
-		assert.Equal(t, "", root)
+		assert.Empty(t, root)
 	})
 }