Commit 965d08b
authored
Re-enable integration test trigger and route cross-org dispatch through emu-access (#5034)
## Summary
- Reverts the intent of #4899 (temporary stub) and restores automatic
integration test triggering. The original PR could not simply be
reverted (as initially intended) because of the new distinction between
runners with cross-org access and ones with same-org access.
- Both upstream blockers are now resolved:
- **eng-dev-ecosystem side:**
[databricks-eng/eng-dev-ecosystem#1252](https://github.com/databricks-eng/eng-dev-ecosystem/pull/1252?timeline_per_page=5)
moved `mark-as-pending` / `mark-as-success` / `mark-as-failure` onto
`linux-ubuntu-latest-ghec-access` runners so cross-org check-run writes
no longer 403 on the `databricks` org allowlist.
- **CLI side (this PR):** the cross-org `gh workflow run` dispatch is
moved onto `linux-ubuntu-latest-emu-access`, following the pattern from
databricks/databricks-sdk-go#1638, so it no longer 403s on the
`databricks-eng` org allowlist.
- The job is split in two:
- `integration-trigger` (deco runners) handles same-org `Integration
Tests` check writes for the PR-skip and merge-group-auto-approve paths,
using the `DECO_TEST_APPROVAL` app token. Testmask-based gating and the
pre-#4899 summaries (`Skipped (changes do not require integration
tests)` / `Auto-approved for merge queue (tests already passed on PR)`)
are restored.
- `trigger-tests` (emu-access runners) mints the `DECO_WORKFLOW_TRIGGER`
token and issues the cross-org `gh workflow run cli-isolated-pr.yml` /
`cli-isolated-nightly.yml` dispatches.
- `integration-trigger-dependabot` is unchanged.
NO_CHANGELOG=true
## Test plan
- [x] On this PR, confirm `integration-trigger` runs on
`databricks-deco-testing-runner-group` and succeeds.
- [x] Confirm `trigger-tests` runs on
`databricks-release-runner-group-emu-access`; `Generate GitHub App
Token` step succeeds (no 403); `Trigger integration tests (pull
request)` dispatches `cli-isolated-pr.yml` on
`databricks-eng/eng-dev-ecosystem` with `pull_request_number` and
`commit_sha` inputs.
- [x] On `databricks-eng/eng-dev-ecosystem`, confirm the dispatched
`cli-isolated-pr` run appears (event: `workflow_dispatch`) and its
`checkout` job uploads the `update-check-action` and `gh-report-action`
artifacts.
- [x] Confirm `mark-as-pending` runs on
`linux-ubuntu-latest-ghec-access` and updates the `Integration Tests`
check on the PR commit to `in_progress`.
- [x] When the `integration-tests-prod` matrix finishes, confirm
`mark-as-success` / `mark-as-failure` updates the check to `success` /
`failure`. (Known separate issue: `integration-tests-prod` on `main` has
been failing due to a Go 1.25.9 toolchain fetch against
`proxy.golang.org`; that is out of scope here.)
- [ ] Merge-queue path: after ready-for-merge, confirm
`integration-trigger` writes the `Auto-approved for merge queue (tests
already passed on PR)` check.
- [ ] Push-to-main path: after merge, confirm a `workflow_dispatch` run
of `cli-isolated-nightly.yml` appears on eng-dev-ecosystem keyed to the
merge commit SHA.
This pull request and its description were written by Isaac.1 parent 45688a4 commit 965d08b
1 file changed
Lines changed: 83 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
376 | 376 | | |
377 | 377 | | |
378 | 378 | | |
379 | | - | |
380 | | - | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
381 | 384 | | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
382 | 388 | | |
383 | 389 | | |
384 | 390 | | |
385 | 391 | | |
386 | 392 | | |
387 | | - | |
388 | | - | |
| 393 | + | |
| 394 | + | |
389 | 395 | | |
390 | 396 | | |
391 | 397 | | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
392 | 401 | | |
393 | 402 | | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
394 | 418 | | |
395 | | - | |
| 419 | + | |
396 | 420 | | |
397 | 421 | | |
| 422 | + | |
398 | 423 | | |
399 | 424 | | |
400 | 425 | | |
| |||
405 | 430 | | |
406 | 431 | | |
407 | 432 | | |
408 | | - | |
| 433 | + | |
409 | 434 | | |
410 | 435 | | |
411 | 436 | | |
| 437 | + | |
412 | 438 | | |
413 | 439 | | |
414 | 440 | | |
415 | 441 | | |
| 442 | + | |
416 | 443 | | |
417 | 444 | | |
418 | 445 | | |
| |||
423 | 450 | | |
424 | 451 | | |
425 | 452 | | |
426 | | - | |
| 453 | + | |
427 | 454 | | |
428 | 455 | | |
429 | 456 | | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
430 | 506 | | |
431 | 507 | | |
432 | 508 | | |
| |||
0 commit comments