Enable 13 more linters and fix all violations (#4997)

## Changes
- Enable 13 additional golangci-lint linters and fix all violations.
Intentional patterns (e.g. deliberate nil-error returns) are annotated
with `//nolint`.
- Fix IPv6-unsafe host:port formatting in apps run-local config
(`fmt.Sprintf` → `net.JoinHostPort`).
- Fix user-facing typos: "paramaters" → "parameters", "app app proxy" →
"app proxy".

## Why
Follow-up to #4978. These linters catch real bugs at compile time
(silently discarded errors, IPv6 breakage) and prevent future
regressions.

## Tests
No new tests. Validated with `golangci-lint run ./...`. One existing
test assertion updated to match a corrected error string.

Author: denik

.golangci.yaml

@@ -21,6 +21,19 @@ linters:
     - forbidigo
     - depguard
     - usestdlibvars
+    - nilerr
+    - fatcontext
+    - nosprintfhostport
+    - recvcheck
+    - usetesting
+    - dupword
+    - misspell
+    - nilnesserr
+    - durationcheck
+    - exptostd
+    - gocheckcompilerdirectives
+    - asciicheck
+    - reassign
   settings:
     depguard:
       rules:

acceptance/acceptance_test.go

@@ -610,7 +610,7 @@ func runTest(t *testing.T,
 	if KeepTmp {
 		tempDirBase := filepath.Join(os.TempDir(), "acceptance")
 		_ = os.Mkdir(tempDirBase, 0o755)
-		tmpDir, err = os.MkdirTemp(tempDirBase, "")
+		tmpDir, err = os.MkdirTemp(tempDirBase, "") //nolint:usetesting // KeepTmp: dir must persist after test for debugging
 		require.NoError(t, err)
 		t.Logf("Created directory: %s", tmpDir)
 	} else if WorkspaceTmpDir {

acceptance/internal/cmd_server.go

@@ -49,10 +49,10 @@ func chdir(t *testing.T, cwd string) func() {
 	require.NotEmpty(t, cwd)
 	prevDir, err := os.Getwd()
 	require.NoError(t, err)
-	err = os.Chdir(cwd)
+	err = os.Chdir(cwd) //nolint:usetesting // must restore before function ends, not at test cleanup
 	require.NoError(t, err)
 	return func() {
-		_ = os.Chdir(prevDir)
+		_ = os.Chdir(prevDir) //nolint:usetesting // see above
 	}
 }
 
@@ -62,15 +62,15 @@ func configureEnv(t *testing.T, env map[string]string) func() {
 	// Set current process's environment to match the input.
 	os.Clearenv()
 	for key, val := range env {
-		os.Setenv(key, val)
+		os.Setenv(key, val) //nolint:usetesting // custom restore needed; t.Setenv can't clearenv+restore all
 	}
 
 	// Function callback to use with defer to restore original environment.
 	return func() {
 		os.Clearenv()
 		for _, kv := range oldEnv {
 			kvs := strings.SplitN(kv, "=", 2)
-			os.Setenv(kvs[0], kvs[1])
+			os.Setenv(kvs[0], kvs[1]) //nolint:usetesting // see above
 		}
 	}
 }

acceptance/internal/prepare_server.go

@@ -44,7 +44,7 @@ func StartDefaultServer(t *testing.T, logRequests bool) {
 	// This approach ensures test reliability across platforms.
 	//
 	// See debugging journey in https://github.com/databricks/cli/pull/3575.
-	homeDir, err := os.MkdirTemp("", "acceptance-home-dir")
+	homeDir, err := os.MkdirTemp("", "acceptance-home-dir") //nolint:usetesting // t.TempDir() fails on Windows; see PR #3575
 	require.NoError(t, err)
 	t.Cleanup(func() {
 		err := os.RemoveAll(homeDir)
@@ -123,7 +123,7 @@ func PrepareServerAndClient(t *testing.T, config TestConfig, logRequests bool, o
 	}
 
 	// For the purposes of replacements, use testUser for local runs.
-	// Note, users might have overriden /api/2.0/preview/scim/v2/Me but that should not affect the replacement:
+	// Note, users might have overridden /api/2.0/preview/scim/v2/Me but that should not affect the replacement:
 	return cfg, testUser
 }
 

bundle/apps/validate.go

@@ -46,7 +46,7 @@ func (v *validate) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics
 			diags = append(diags, diag.Diagnostic{
 				Severity:  diag.Error,
 				Summary:   "Duplicate app source code path",
-				Detail:    fmt.Sprintf("app resource '%s' has the same source code path as app resource '%s', this will lead to the app configuration being overriden by each other", key, usedSourceCodePaths[app.SourceCodePath]),
+				Detail:    fmt.Sprintf("app resource '%s' has the same source code path as app resource '%s', this will lead to the app configuration being overridden by each other", key, usedSourceCodePaths[app.SourceCodePath]),
 				Locations: b.Config.GetLocations(fmt.Sprintf("resources.apps.%s.source_code_path", key)),
 			})
 		}

bundle/artifacts/prepare.go

@@ -117,7 +117,7 @@ func InsertPythonArtifact(ctx context.Context, b *bundle.Bundle) error {
 	_, err := os.Stat(setupPy)
 	if err != nil {
 		log.Infof(ctx, "No Python wheel project found at bundle root folder")
-		return nil
+		return nil //nolint:nilerr // setup.py not found means no wheel project to detect
 	}
 
 	log.Infof(ctx, "Found Python wheel project at %s", b.BundleRootPath)

bundle/config/mutator/resourcemutator/apply_target_mode.go

@@ -23,7 +23,7 @@ func (m *applyTargetMode) Name() string {
 }
 
 // Mark all resources as being for 'development' purposes, i.e.
-// changing their their name, adding tags, and (in the future)
+// changing their name, adding tags, and (in the future)
 // marking them as 'hidden' in the UI.
 func transformDevelopmentMode(ctx context.Context, b *bundle.Bundle) {
 	if !b.Config.Bundle.Deployment.Lock.IsExplicitlyEnabled() {

bundle/config/mutator/rewrite_workspace_prefix.go

@@ -12,7 +12,7 @@ import (
 
 type rewriteWorkspacePrefix struct{}
 
-// RewriteWorkspacePrefix finds any strings in bundle configration that have
+// RewriteWorkspacePrefix finds any strings in bundle configuration that have
 // workspace prefix plus workspace path variable used and removes workspace prefix from it.
 func RewriteWorkspacePrefix() bundle.Mutator {
 	return &rewriteWorkspacePrefix{}

bundle/config/mutator/set_variables_test.go

@@ -122,7 +122,7 @@ func TestSetVariablesMutator(t *testing.T) {
 					Default:     defaultValForA,
 				},
 				"b": {
-					Description: "resolved from environment vairables",
+					Description: "resolved from environment variables",
 					Default:     defaultValForB,
 				},
 				"c": {

bundle/config/resources/secret_scope.go

@@ -28,7 +28,7 @@ type SecretScopePermission struct {
 	GroupName            string `json:"group_name,omitempty"`
 }
 
-type SecretScope struct {
+type SecretScope struct { //nolint:recvcheck // pointer receiver needed for UnmarshalJSON, value for other methods
 	BaseResource
 
 	// A unique name to identify the secret scope.
@@ -67,7 +67,7 @@ func (s SecretScope) Exists(ctx context.Context, w *databricks.WorkspaceClient,
 	// The indirect methods are not semantically ideal for simple existence checks, so we use the list API here
 	scopes, err := w.Secrets.ListScopesAll(ctx)
 	if err != nil {
-		return false, nil
+		return false, nil //nolint:nilerr // treat API errors as "scope not found"
 	}
 
 	for _, scope := range scopes {