tests: set USERPROFILE alongside HOME so Windows test job picks up the right tempdir

Moving aitools to top-level cmd/ and libs/ means TEST_PACKAGES on Windows
now runs these tests via ./cmd/... and ./libs/... globs; previously they
lived under experimental/aitools/, which Windows skipped. The tests set
HOME, but env.HomeEnvVar() returns "USERPROFILE" on Windows.

Set both env vars at every call site, following the libs/git pattern.

Co-authored-by: Isaac

Author: simonfaltum

cmd/aitools/install_test.go

@@ -53,6 +53,7 @@ func setupTestAgents(t *testing.T) string {
 	t.Helper()
 	tmp := t.TempDir()
 	t.Setenv("HOME", tmp)
+	t.Setenv("USERPROFILE", tmp)
 	// Create config dirs for two agents.
 	require.NoError(t, os.MkdirAll(filepath.Join(tmp, ".claude"), 0o755))
 	require.NoError(t, os.MkdirAll(filepath.Join(tmp, ".cursor"), 0o755))
@@ -224,6 +225,7 @@ func TestInstallNonInteractiveUsesAllAgents(t *testing.T) {
 func TestInstallNoAgentsDetected(t *testing.T) {
 	tmp := t.TempDir()
 	t.Setenv("HOME", tmp)
+	t.Setenv("USERPROFILE", tmp)
 
 	calls := setupInstallMock(t)
 	ctx := cmdio.MockDiscard(t.Context())

cmd/aitools/version_test.go

@@ -15,6 +15,7 @@ import (
 func TestVersionShowsBothScopes(t *testing.T) {
 	tmp := t.TempDir()
 	t.Setenv("HOME", tmp)
+	t.Setenv("USERPROFILE", tmp)
 	t.Setenv("DATABRICKS_SKILLS_REF", "v0.1.0")
 
 	// Create global state.
@@ -70,6 +71,7 @@ func TestVersionShowsBothScopes(t *testing.T) {
 func TestVersionShowsSingleScopeWithoutQualifier(t *testing.T) {
 	tmp := t.TempDir()
 	t.Setenv("HOME", tmp)
+	t.Setenv("USERPROFILE", tmp)
 	t.Setenv("DATABRICKS_SKILLS_REF", "v0.1.0")
 
 	// Create only global state.

libs/aitools/agents/recommend_test.go

@@ -17,6 +17,7 @@ func noopInstall(context.Context) error { return nil }
 func TestRecommendSkillsInstallSkipsWhenSkillsExist(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
+	t.Setenv("USERPROFILE", tmpDir)
 	// Skills must be in canonical location to be detected.
 	require.NoError(t, os.MkdirAll(filepath.Join(tmpDir, CanonicalSkillsDir, "databricks"), 0o755))
 
@@ -39,7 +40,9 @@ func TestRecommendSkillsInstallSkipsWhenSkillsExist(t *testing.T) {
 }
 
 func TestRecommendSkillsInstallSkipsWhenNoAgents(t *testing.T) {
-	t.Setenv("HOME", t.TempDir())
+	tmp := t.TempDir()
+	t.Setenv("HOME", tmp)
+	t.Setenv("USERPROFILE", tmp)
 
 	origRegistry := Registry
 	Registry = []Agent{}
@@ -53,6 +56,7 @@ func TestRecommendSkillsInstallSkipsWhenNoAgents(t *testing.T) {
 func TestRecommendSkillsInstallNonInteractive(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
+	t.Setenv("USERPROFILE", tmpDir)
 
 	origRegistry := Registry
 	Registry = []Agent{
@@ -73,6 +77,7 @@ func TestRecommendSkillsInstallNonInteractive(t *testing.T) {
 func TestRecommendSkillsInstallInteractiveDecline(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
+	t.Setenv("USERPROFILE", tmpDir)
 
 	origRegistry := Registry
 	Registry = []Agent{

libs/aitools/agents/skills_test.go

@@ -21,6 +21,7 @@ func TestHasDatabricksSkillsInstalledNoAgents(t *testing.T) {
 func TestHasDatabricksSkillsInstalledCanonicalOnly(t *testing.T) {
 	tmpHome := t.TempDir()
 	t.Setenv("HOME", tmpHome)
+	t.Setenv("USERPROFILE", tmpHome)
 	require.NoError(t, os.MkdirAll(filepath.Join(tmpHome, CanonicalSkillsDir, "databricks"), 0o755))
 
 	origRegistry := Registry
@@ -39,6 +40,7 @@ func TestHasDatabricksSkillsInstalledCanonicalOnly(t *testing.T) {
 func TestHasDatabricksSkillsInstalledIgnoresAgentDir(t *testing.T) {
 	tmpHome := t.TempDir()
 	t.Setenv("HOME", tmpHome)
+	t.Setenv("USERPROFILE", tmpHome)
 	// Skills in agent dir only (e.g., installed by another tool) should not count.
 	agentDir := filepath.Join(tmpHome, ".claude")
 	require.NoError(t, os.MkdirAll(filepath.Join(agentDir, "skills", "databricks"), 0o755))
@@ -59,6 +61,7 @@ func TestHasDatabricksSkillsInstalledIgnoresAgentDir(t *testing.T) {
 func TestHasDatabricksSkillsInstalledWithOnlyNonDatabricksSkills(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
+	t.Setenv("USERPROFILE", tmpDir)
 	// Non-databricks skills should not count.
 	require.NoError(t, os.MkdirAll(filepath.Join(tmpDir, "skills", "mcp-builder"), 0o755))
 	require.NoError(t, os.MkdirAll(filepath.Join(tmpDir, "skills", "rust-webapp"), 0o755))
@@ -79,6 +82,7 @@ func TestHasDatabricksSkillsInstalledWithOnlyNonDatabricksSkills(t *testing.T) {
 func TestHasDatabricksSkillsInstalledNoSkillsDir(t *testing.T) {
 	tmpDir := t.TempDir()
 	t.Setenv("HOME", tmpDir)
+	t.Setenv("USERPROFILE", tmpDir)
 
 	origRegistry := Registry
 	Registry = []Agent{
@@ -96,6 +100,7 @@ func TestHasDatabricksSkillsInstalledNoSkillsDir(t *testing.T) {
 func TestHasDatabricksSkillsInstalledCustomSubdirNotChecked(t *testing.T) {
 	tmpHome := t.TempDir()
 	t.Setenv("HOME", tmpHome)
+	t.Setenv("USERPROFILE", tmpHome)
 	// Skills in agent's custom subdir should not count — only canonical matters.
 	require.NoError(t, os.MkdirAll(filepath.Join(tmpHome, ".gemini", "antigravity", "global_skills", "databricks"), 0o755))
 
@@ -116,6 +121,7 @@ func TestHasDatabricksSkillsInstalledCustomSubdirNotChecked(t *testing.T) {
 func TestHasDatabricksSkillsInstalledDatabricksAppsCanonical(t *testing.T) {
 	tmpHome := t.TempDir()
 	t.Setenv("HOME", tmpHome)
+	t.Setenv("USERPROFILE", tmpHome)
 	// databricks-apps prefix should match in canonical location.
 	require.NoError(t, os.MkdirAll(filepath.Join(tmpHome, CanonicalSkillsDir, "databricks-apps"), 0o755))
 
@@ -138,6 +144,7 @@ func TestHasDatabricksSkillsInstalledDatabricksAppsCanonical(t *testing.T) {
 func TestHasDatabricksSkillsInstalledLegacyPath(t *testing.T) {
 	tmpHome := t.TempDir()
 	t.Setenv("HOME", tmpHome)
+	t.Setenv("USERPROFILE", tmpHome)
 	// Skills only in the legacy location should still be detected.
 	require.NoError(t, os.MkdirAll(filepath.Join(tmpHome, legacySkillsDir, "databricks"), 0o755))
 

libs/aitools/installer/installer_test.go

@@ -72,6 +72,7 @@ func setupTestHome(t *testing.T) string {
 	t.Helper()
 	tmp := t.TempDir()
 	t.Setenv("HOME", tmp)
+	t.Setenv("USERPROFILE", tmp)
 	// Create agent config dir so the agent is "detected".
 	require.NoError(t, os.MkdirAll(filepath.Join(tmp, ".test-agent"), 0o755))
 	return tmp