Commit c19a115
authored
auth: honor --host on
## Why
\`databricks auth describe --host X\` silently ignored the flag. The
value was bound to the parent \`auth\` command's \`authArguments.Host\`
but never read by the describe flow, so the SDK fell back to
\`[__settings__].default_profile\` (silently describing a different host
than the one named) or the \"default auth: cannot configure default
credentials\" error even when a host-matching profile existed. The
display still labelled the value \`(from --host flag)\`, making the
mismatch hard to spot. Reported in a bug bash.
Reproduced against \`db-deco-test.databricks.com\` (which has two
matching profiles in my .databrickscfg):
\`\`\`
$ databricks auth describe --host https://db-deco-test.databricks.com
Host: https://dogfood.staging.databricks.com ← actually dogfood, not
db-deco-test
✓ host: https://dogfood.staging.databricks.com (from --host flag) ←
misleading label
✓ profile: dogfood
\`\`\`
## Changes
- \`describe.go\`: when \`--host\` is set without \`--profile\`, resolve
the host to a profile name via the existing \`resolveHostToProfile\` and
set \`--profile\` so the downstream \`MustAnyClient\` uses it.
\`DATABRICKS_CONFIG_PROFILE\` is left alone — it's an explicit user
signal.
- \`resolve.go\`: when multiple profiles match a host, prefer
\`[__settings__].default_profile\` if it's one of the matches before
falling back to the picker or ambiguity error. The same helper is used
by \`auth logout\`, which gets the same UX improvement (no prompt when
the user's default already disambiguates).
After the fix, against the same host:
\`\`\`
$ databricks auth describe --host https://db-deco-test.databricks.com
Error: multiple profiles found matching host
\"https://db-deco-test.databricks.com\":
spog-deco-aws, db-deco-test-chrisst. Please specify the profile name
directly
\`\`\`
And with \`default_profile = spog-deco-aws\` in \`[__settings__]\`, the
same command auto-selects \`spog-deco-aws\` without prompting.
## Test plan
- [x] Reproduced against \`db-deco-test.databricks.com\`: confirmed the
original bug (default profile silently used, misleading source label).
- [x] After the fix: single-host-match case picks the matching profile,
multi-match case prefers the configured default, no-match case gives a
clean error.
- [x] No-flag case still uses \`default_profile\` as before — no
regression.
- [x] New unit test:
\`TestResolveHostToProfilePrefersConfiguredDefault\`.
- [x] \`go test ./cmd/auth/...\`, \`./task checks\`, \`./task lint-q\`.auth describe and prefer default profile when host is ambiguous (#5343)1 parent c8ea3a8 commit c19a115
4 files changed
Lines changed: 146 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
68 | 72 | | |
69 | 73 | | |
70 | 74 | | |
| |||
85 | 89 | | |
86 | 90 | | |
87 | 91 | | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
88 | 119 | | |
89 | 120 | | |
90 | 121 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| |||
16 | 18 | | |
17 | 19 | | |
18 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
19 | 82 | | |
20 | 83 | | |
21 | 84 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
| 13 | + | |
| 14 | + | |
12 | 15 | | |
13 | 16 | | |
14 | 17 | | |
| |||
72 | 75 | | |
73 | 76 | | |
74 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
75 | 89 | | |
76 | 90 | | |
77 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
4 | 6 | | |
5 | 7 | | |
6 | 8 | | |
| |||
113 | 115 | | |
114 | 116 | | |
115 | 117 | | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
116 | 124 | | |
117 | 125 | | |
118 | 126 | | |
| |||
127 | 135 | | |
128 | 136 | | |
129 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
130 | 168 | | |
131 | 169 | | |
132 | 170 | | |
| |||
0 commit comments