Skip to content

Commit c793668

Browse files
committed
Address Cursor review: clarify changelog and use .test TLD in fixture
- Changelog now notes that DATABRICKS_HOST still takes precedence over default_profile for `databricks auth token` (matches resolveNoArgsToken Step 1). - Switch the auth token acceptance fixture from https://myworkspace.cloud.databricks.com to https://myworkspace.test per the repo's RFC 2606 convention; same for the secondary "other" profile in that file. Avoids reintroducing DNS/network flakiness. Co-authored-by: Isaac
1 parent a606de7 commit c793668

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

NEXT_CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
* `databricks auth describe` now reports where U2M (`databricks-cli`) tokens are stored: `plaintext` (`~/.databricks/token-cache.json`) or `secure` (OS keyring), and the source of the choice (env var, config setting, or default).
88
* Marked the default profile in the interactive pickers shown by `databricks auth switch`, `databricks auth logout`, `databricks auth token`, and `databricks auth login`, and moved it to the top of the list. `databricks auth login` and `databricks auth logout` now offer the same selectors as `databricks auth token` and `databricks auth switch` respectively.
9-
* `[__settings__].default_profile` is now honored by `databricks api`, `databricks auth token`, and bundle commands when no `--profile` flag and no `DATABRICKS_CONFIG_PROFILE` env var is set. For bundle commands, `default_profile` only applies when the bundle does not pin its own `workspace.host`.
9+
* `[__settings__].default_profile` is now consulted as a fallback by `databricks api`, `databricks auth token`, and bundle commands when neither `--profile` nor `DATABRICKS_CONFIG_PROFILE` is set. `databricks auth token` continues to give precedence to `DATABRICKS_HOST` over `default_profile`. For bundle commands, `default_profile` only applies when the bundle does not pin its own `workspace.host`.
1010

1111
### Bundles
1212

acceptance/cmd/auth/token/default-profile/output.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
=== default_profile is honored when no args, --profile, or env var
33

44
>>> errcode [CLI] auth token
5-
Warn: [hostmetadata] failed to fetch host metadata for https://myworkspace.cloud.databricks.com, will skip for 1m0s
5+
Warn: [hostmetadata] failed to fetch host metadata for https://myworkspace.test, will skip for 1m0s
66
Error: cache: databricks OAuth is not configured for this host. Try logging in again with `databricks auth login --profile myprofile` before retrying. If this fails, please report this issue to the Databricks CLI maintainers at https://github.com/databricks/cli/issues/new
77

88
Exit code: 1

acceptance/cmd/auth/token/default-profile/script

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ unset DATABRICKS_CONFIG_PROFILE
88
# through to the non-interactive error "no profile specified".
99
cat > "./home/.databrickscfg" <<'ENDCFG'
1010
[myprofile]
11-
host = https://myworkspace.cloud.databricks.com
11+
host = https://myworkspace.test
1212
auth_type = databricks-cli
1313

1414
[other]
15-
host = https://other.example
15+
host = https://other.test
1616
auth_type = databricks-cli
1717

1818
[__settings__]
@@ -25,7 +25,7 @@ trace errcode $CLI auth token
2525
title "default_profile pointing at a missing profile falls through to picker\n"
2626
cat > "./home/.databrickscfg" <<'ENDCFG'
2727
[myprofile]
28-
host = https://myworkspace.cloud.databricks.com
28+
host = https://myworkspace.test
2929
auth_type = databricks-cli
3030

3131
[__settings__]

0 commit comments

Comments
 (0)