Address review: use apierr.IsMissing in Exists, SDK LRO in DoCreate/DoUpdate

Co-authored-by: Isaac

Author: bernardo-rodriguez

bundle/config/resources/app_spaces.go

@@ -6,6 +6,7 @@ import (
 
 	"github.com/databricks/cli/libs/log"
 	"github.com/databricks/databricks-sdk-go"
+	"github.com/databricks/databricks-sdk-go/apierr"
 	"github.com/databricks/databricks-sdk-go/marshal"
 	"github.com/databricks/databricks-sdk-go/service/apps"
 )
@@ -28,7 +29,10 @@ func (s AppSpace) MarshalJSON() ([]byte, error) {
 func (s *AppSpace) Exists(ctx context.Context, w *databricks.WorkspaceClient, id string) (bool, error) {
 	_, err := w.Apps.GetSpace(ctx, apps.GetSpaceRequest{Name: id})
 	if err != nil {
-		log.Debugf(ctx, "app space %s does not exist", id)
+		log.Debugf(ctx, "app space with id %s does not exist: %v", id, err)
+		if apierr.IsMissing(err) {
+			return false, nil
+		}
 		return false, err
 	}
 	return true, nil

bundle/direct/dresources/app_space.go

@@ -2,13 +2,10 @@ package dresources
 
 import (
 	"context"
-	"fmt"
-	"time"
 
 	"github.com/databricks/cli/bundle/config/resources"
 	"github.com/databricks/databricks-sdk-go"
 	"github.com/databricks/databricks-sdk-go/common/types/fieldmask"
-	"github.com/databricks/databricks-sdk-go/retries"
 	"github.com/databricks/databricks-sdk-go/service/apps"
 )
 
@@ -29,53 +26,29 @@ func (r *ResourceAppSpace) DoRead(ctx context.Context, id string) (*apps.Space,
 }
 
 func (r *ResourceAppSpace) DoCreate(ctx context.Context, config *apps.Space) (string, *apps.Space, error) {
-	// Kick off the create request. Wait for the space to become active in
-	// WaitAfterCreate so that parallel creates are not blocked here.
-	_, err := r.client.Apps.CreateSpace(ctx, apps.CreateSpaceRequest{
+	waiter, err := r.client.Apps.CreateSpace(ctx, apps.CreateSpaceRequest{
 		Space: *config,
 	})
 	if err != nil {
 		return "", nil, err
 	}
-	return config.Name, nil, nil
+	space, err := waiter.Wait(ctx)
+	if err != nil {
+		return "", nil, err
+	}
+	return space.Name, space, nil
 }
 
 func (r *ResourceAppSpace) DoUpdate(ctx context.Context, id string, config *apps.Space, _ *PlanEntry) (*apps.Space, error) {
-	_, err := r.client.Apps.UpdateSpace(ctx, apps.UpdateSpaceRequest{
+	waiter, err := r.client.Apps.UpdateSpace(ctx, apps.UpdateSpaceRequest{
 		Name:       id,
 		Space:      *config,
 		UpdateMask: fieldmask.FieldMask{Paths: []string{"description", "resources", "user_api_scopes", "usage_policy_id"}},
 	})
-	return nil, err
-}
-
-func (r *ResourceAppSpace) WaitAfterCreate(ctx context.Context, config *apps.Space) (*apps.Space, error) {
-	return r.waitForSpaceActive(ctx, config.Name)
-}
-
-func (r *ResourceAppSpace) WaitAfterUpdate(ctx context.Context, config *apps.Space) (*apps.Space, error) {
-	return r.waitForSpaceActive(ctx, config.Name)
-}
-
-func (r *ResourceAppSpace) waitForSpaceActive(ctx context.Context, name string) (*apps.Space, error) {
-	retrier := retries.New[apps.Space](retries.WithTimeout(20 * time.Minute))
-	return retrier.Run(ctx, func(ctx context.Context) (*apps.Space, error) {
-		space, err := r.client.Apps.GetSpace(ctx, apps.GetSpaceRequest{Name: name})
-		if err != nil {
-			return nil, retries.Halt(err)
-		}
-		if space.Status == nil {
-			return nil, retries.Continues("waiting for status")
-		}
-		switch space.Status.State {
-		case apps.SpaceStatusSpaceStateSpaceActive:
-			return space, nil
-		case apps.SpaceStatusSpaceStateSpaceError:
-			return nil, retries.Halt(fmt.Errorf("space %s is in ERROR state: %s", name, space.Status.Message))
-		default:
-			return nil, retries.Continues(fmt.Sprintf("space state: %s", space.Status.State))
-		}
-	})
+	if err != nil {
+		return nil, err
+	}
+	return waiter.Wait(ctx)
 }
 
 func (r *ResourceAppSpace) DoDelete(ctx context.Context, id string) error {