Skip to content

Commit ef90f53

Browse files
authored
acceptance: skip pydabs_1000_tasks in migrate + continue_293 invariants (#5062)
Drop `job_pydabs_1000_tasks` from the `migrate` and `continue_293` invariants — they are the top-2 slowest acceptance tests on `*/direct` jobs. `no_drift` still runs the same 1000-task config every PR, so the deploy + plan path stays covered at scale. We do lose some coverage: scale-specific bugs in the terraform→direct state migration path (`migrate`) or in v0.293.0-state back-compat (`continue_293`) wouldn't be caught at 1000 tasks anymore. Both invariants still run their full set of other configs every PR. Given how heavy these two tests are, the trade-off is worth it. The real fix is to make the 1000-task case fast in principle, but that's a separate effort. This PR buys back PR-CI time today; speeding up the underlying path is what makes the dropped coverage cheap to restore later. Measured savings vs main: - linux/direct: 8m47s → 5m20s - macos/direct: 11m9s → 8m19s - windows/direct: 25m44s → 24m15s This pull request and its description were written by Isaac.
1 parent 0522580 commit ef90f53

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

acceptance/bundle/invariant/continue_293/test.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,7 @@ EnvMatrixExclude.no_vector_search_endpoint = ["INPUT_CONFIG=vector_search_endpoi
1111

1212
# Dotted pipeline configuration keys are not supported on v0.293.0
1313
EnvMatrixExclude.no_pipeline_config_dots = ["INPUT_CONFIG=pipeline_config_dots.yml.tmpl"]
14+
15+
# The 1000-task scale case is covered by no_drift. Running it here adds ~1.5 min
16+
# per variant (two full deploys at 1000 tasks) without incremental coverage.
17+
EnvMatrixExclude.no_pydabs_1000_tasks = ["INPUT_CONFIG=job_pydabs_1000_tasks.yml.tmpl"]

acceptance/bundle/invariant/migrate/test.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,7 @@ EnvMatrixExclude.no_grant_ref = ["INPUT_CONFIG=schema_grant_ref.yml.tmpl"]
1919

2020
# SQL warehouses currently failing with migration with permanent drift. TODO: fix this.
2121
EnvMatrixExclude.no_sql_warehouse = ["INPUT_CONFIG=sql_warehouse.yml.tmpl"]
22+
23+
# The 1000-task scale case is covered by no_drift. Running it here adds ~1.5 min
24+
# per variant (deploy + migrate + plan at 1000 tasks) without incremental coverage.
25+
EnvMatrixExclude.no_pydabs_1000_tasks = ["INPUT_CONFIG=job_pydabs_1000_tasks.yml.tmpl"]

0 commit comments

Comments
 (0)