Skip to content

Commit f157bd1

Browse files
authored
ci: stop canceling PR approval workflow runs (#5566)
The `PR approval` workflow canceled in-flight runs via concurrency (`cancel-in-progress: true`). A canceled run leaves its own failing `check` check-run, and since GitHub keeps one check-run per run rather than per name, a later passing run doesn't clear it — the commit stays red until that run is re-run. `cancel-in-progress: false` wouldn't be enough, since concurrency also cancels pending runs by default, so this drops the block entirely; the check is idempotent and ~20s, so letting every run finish is harmless. Found while investigating a stray red ✗ on an unrelated PR that lingered even after the same workflow had passed. This pull request and its description were written by Isaac.
1 parent 18cac62 commit f157bd1

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/maintainer-approval.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ on:
88
merge_group:
99
types: [checks_requested]
1010

11-
concurrency:
12-
group: pr-approval-${{ github.event.pull_request.number || github.event.merge_group.head_sha }}
13-
cancel-in-progress: true
11+
# No concurrency group: a run cancelled by concurrency leaves a stuck failing
12+
# check, since each run posts its own check-run and a later passing run does not
13+
# clear it. The check is cheap and idempotent, so let every run finish instead.
1414

1515
defaults:
1616
run:

0 commit comments

Comments
 (0)