Fix config sync for perfomance mode and timeouts#4908
Merged
Conversation
ilyakuz-db
commented
Apr 7, 2026
| email_notifications.on_failure[0]: replace | ||
| max_concurrent_runs: replace | ||
| tags['env']: remove | ||
| timeout_seconds: remove |
Contributor
Author
There was a problem hiding this comment.
This is expected, test output was incorrect (field was skipped unconditionally)
ilyakuz-db
changed the title
ilyakuz-db
changed the title
ilyakuz-db
requested review from
andrewnester,
anton-107,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
Contributor
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: high Eligible reviewersBased on CODEOWNERS, these people or teams could also review: @andrewnester, @anton-107, @pietern, @shreyas-goenka, @simonfaltum Suggestions based on git history of 3 changed files (2 scored). See CODEOWNERS for path-specific ownership rules. |
denik
approved these changes
Apr 10, 2026
denik
pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Use the same logic for server-side defaults as in resources.yml logic. I have a PR that updates `config-remote-sync` to use `resources.yml`, but it's not yet ready to merge #4677 ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> Changes in performance mode were incorrectly ignored previously ## Tests <!-- How have you tested the changes? --> <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use the same logic for server-side defaults as in resources.yml logic.
I have a PR that updates
config-remote-syncto useresources.yml, but it's not yet ready to merge #4677Why
Changes in performance mode were incorrectly ignored previously
Tests