Skip to content

Track bundle resource state sizes in telemetry (direct engine)#5199

Merged
shreyas-goenka merged 1 commit into
mainfrom
shreyas-goenka/state-size-telemetry
Jun 9, 2026
Merged

Track bundle resource state sizes in telemetry (direct engine)#5199
shreyas-goenka merged 1 commit into
mainfrom
shreyas-goenka/state-size-telemetry

Conversation

@shreyas-goenka

@shreyas-goenka shreyas-goenka commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds a resources_metadata field to the bundle deploy telemetry event with, per resource type, the count and the max/mean/median state size in bytes, plus the whole state file size.

@shreyas-goenka shreyas-goenka mentioned this pull request May 6, 2026
Closed
@shreyas-goenka shreyas-goenka force-pushed the shreyas-goenka/state-size-telemetry branch from 4a3106b to 715f019 Compare May 6, 2026 18:07
@shreyas-goenka shreyas-goenka force-pushed the shreyas-goenka/state-size-telemetry branch from 715f019 to 77ec7bc Compare May 6, 2026 18:32
@shreyas-goenka shreyas-goenka force-pushed the shreyas-goenka/state-size-telemetry branch from 77ec7bc to 85dd380 Compare May 6, 2026 18:49
@shreyas-goenka shreyas-goenka force-pushed the shreyas-goenka/state-size-telemetry branch from 85dd380 to 65bb595 Compare June 2, 2026 09:41
@shreyas-goenka shreyas-goenka force-pushed the shreyas-goenka/state-size-telemetry branch from 65bb595 to 44e4bc0 Compare June 2, 2026 10:10
@shreyas-goenka shreyas-goenka changed the title Track bundle resource counts and state file sizes in telemetry stats: Record per resource state file statistics in telemetry Jun 2, 2026
@shreyas-goenka shreyas-goenka marked this pull request as ready for review June 2, 2026 10:14
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Commit: d0b2183

Run: 27206639157

Env ❌​FAIL 🟨​KNOWN 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
🟨​ aws linux 7 15 261 926 7:56
🟨​ aws windows 7 15 263 924 15:15
❌​ aws-ucws linux 117 1 6 15 240 840 7:48
❌​ aws-ucws windows 118 1 6 15 241 838 12:39
💚​ azure linux 1 17 264 924 7:00
💚​ azure windows 1 17 266 922 10:50
💚​ azure-ucws linux 1 17 362 836 7:38
💚​ azure-ucws windows 1 17 364 834 12:07
💚​ gcp linux 1 17 260 927 8:10
💚​ gcp windows 1 17 262 925 10:56
140 interesting tests: 118 FAIL, 15 SKIP, 7 KNOWN
Test Name aws linux aws windows aws-ucws linux aws-ucws windows azure linux azure windows azure-ucws linux azure-ucws windows gcp linux gcp windows
🟨​ TestAccept 🟨​K 🟨​K 🟨​K 🟨​K 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
❌​ TestAccept/bundle/destroy/jobs-and-pipeline ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestAccept/bundle/destroy/jobs-and-pipeline/DATABRICKS_BUNDLE_ENGINE=direct ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestAccept/bundle/destroy/jobs-and-pipeline/DATABRICKS_BUNDLE_ENGINE=terraform ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
🙈​ TestAccept/bundle/invariant/no_drift 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/permissions 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions 🟨​K 🟨​K 💚​R 💚​R 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=direct 🟨​K 🟨​K 💚​R 💚​R
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=terraform 🟨​K 🟨​K 💚​R 💚​R
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions 🟨​K 🟨​K 💚​R 💚​R 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=direct 🟨​K 🟨​K 💚​R 💚​R
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=terraform 🟨​K 🟨​K 💚​R 💚​R
🙈​ TestAccept/bundle/resources/postgres_branches/basic 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_branches/recreate 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_branches/replace_existing 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_branches/update_protected 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_branches/without_branch_id 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_endpoints/basic 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_endpoints/recreate 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_projects/update_display_name 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/synced_database_tables/basic 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_indexes/basic 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_indexes/grants/select 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
❌​ TestAccept/selftest/record_cloud/pipeline-crud ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestAccept/selftest/record_cloud/pipeline-crud/DATABRICKS_BUNDLE_ENGINE=direct ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestAccept/selftest/record_cloud/pipeline-crud/DATABRICKS_BUNDLE_ENGINE=terraform ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
🙈​ TestAccept/ssh/connection 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
❌​ TestApiPost ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCat ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCat/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCatDoesNotSupportOutputModeJson ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCatOnADir ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCatOnADir/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCatOnNonExistentFile ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCatOnNonExistentFile/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCompletion ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDir ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDir/dbfs_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDir/dbfs_to_local ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDir/dbfs_to_uc-volumes 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpDir/local_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDir/uc-volumes_to_dbfs 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpDirToDirFileNotOverwritten ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDirToDirFileNotOverwritten/dbfs_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDirToDirFileNotOverwritten/dbfs_to_local ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDirToDirFileNotOverwritten/dbfs_to_uc-volumes 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpDirToDirFileNotOverwritten/local_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDirToDirFileNotOverwritten/uc-volumes_to_dbfs 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpDirToDirWithOverwriteFlag ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDirToDirWithOverwriteFlag/dbfs_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDirToDirWithOverwriteFlag/dbfs_to_local ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDirToDirWithOverwriteFlag/dbfs_to_uc-volumes 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpDirToDirWithOverwriteFlag/local_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpDirToDirWithOverwriteFlag/uc-volumes_to_dbfs 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpErrorsWhenSourceIsDirWithoutRecursiveFlag ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpErrorsWhenSourceIsDirWithoutRecursiveFlag/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDir ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDir/dbfs_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDir/dbfs_to_local ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDir/dbfs_to_uc-volumes 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToDir/local_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDir/uc-volumes_to_dbfs 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToDirFileNotOverwritten ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDirFileNotOverwritten/dbfs_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDirFileNotOverwritten/dbfs_to_local ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDirFileNotOverwritten/dbfs_to_uc-volumes 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToDirFileNotOverwritten/local_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDirFileNotOverwritten/uc-volumes_to_dbfs 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToDirForWindowsPaths 🙈​s ✅​p 🙈​s ❌​F 🙈​s ✅​p 🙈​s ✅​p 🙈​s ✅​p
❌​ TestFsCpFileToDirWithOverwriteFlag ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDirWithOverwriteFlag/dbfs_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDirWithOverwriteFlag/dbfs_to_local ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDirWithOverwriteFlag/dbfs_to_uc-volumes 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToDirWithOverwriteFlag/local_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToDirWithOverwriteFlag/uc-volumes_to_dbfs 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToFile ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToFile/dbfs_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToFile/dbfs_to_local ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToFile/dbfs_to_uc-volumes 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToFile/local_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToFile/uc-volumes_to_dbfs 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToFileFileNotOverwritten ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToFileFileNotOverwritten/dbfs_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToFileFileNotOverwritten/dbfs_to_local ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToFileFileNotOverwritten/dbfs_to_uc-volumes 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToFileFileNotOverwritten/local_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToFileFileNotOverwritten/uc-volumes_to_dbfs 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToFileWithOverwriteFlag ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToFileWithOverwriteFlag/dbfs_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToFileWithOverwriteFlag/dbfs_to_local ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToFileWithOverwriteFlag/dbfs_to_uc-volumes 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToFileWithOverwriteFlag/local_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToFileWithOverwriteFlag/uc-volumes_to_dbfs 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToNonExistentDir ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToNonExistentDir/dbfs_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToNonExistentDir/dbfs_to_local ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToNonExistentDir/dbfs_to_uc-volumes 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpFileToNonExistentDir/local_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpFileToNonExistentDir/uc-volumes_to_dbfs 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpSourceIsDirectoryButTargetIsFile ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpSourceIsDirectoryButTargetIsFile/dbfs_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpSourceIsDirectoryButTargetIsFile/dbfs_to_local ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpSourceIsDirectoryButTargetIsFile/dbfs_to_uc-volumes 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsCpSourceIsDirectoryButTargetIsFile/local_to_dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsCpSourceIsDirectoryButTargetIsFile/uc-volumes_to_dbfs 🙈​s 🙈​s ❌​F ❌​F 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s
❌​ TestFsLs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsLs/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsLsForNonexistingDir ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsLsForNonexistingDir/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsLsOnEmptyDir ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsLsOnEmptyDir/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsLsOnFile ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsLsOnFile/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsLsWithAbsolutePaths ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsLsWithAbsolutePaths/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsMkdir ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsMkdir/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsMkdirCreatesIntermediateDirectories ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsMkdirCreatesIntermediateDirectories/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsMkdirWhenDirectoryAlreadyExists ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsMkdirWhenDirectoryAlreadyExists/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsMkdirWhenFileExistsAtPath ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsMkdirWhenFileExistsAtPath/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsRmDirRecursively ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsRmDirRecursively/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsRmEmptyDir ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsRmEmptyDir/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsRmFile ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsRmFile/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsRmForNonExistentFile ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsRmForNonExistentFile/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsRmNonEmptyDirectory ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFsRmNonEmptyDirectory/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFilerReadDir ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFilerReadDir/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFilerReadWrite ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFilerReadWrite/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFilerRecursiveDelete ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
❌​ TestFilerRecursiveDelete/dbfs ✅​p ✅​p ❌​F ❌​F ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
Top 26 slowest tests (at least 2 minutes):
duration env testname
6:10 azure-ucws windows TestAccept
5:58 azure windows TestAccept
5:52 gcp windows TestAccept
4:54 gcp windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
4:50 gcp linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
4:38 gcp linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
4:29 gcp windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:42 azure-ucws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:10 aws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:08 azure-ucws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:04 aws-ucws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:03 aws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:02 aws-ucws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:01 aws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:00 aws-ucws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:57 azure-ucws linux TestAccept
2:56 azure windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:56 gcp linux TestAccept
2:51 azure linux TestAccept
2:39 azure windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:39 azure linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:37 azure-ucws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:31 azure-ucws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:31 azure linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:27 aws-ucws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:25 aws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct

denik
denik reviewed Jun 3, 2026
View reviewed changes
Comment thread bundle/phases/resources_metadata.go Outdated
db := dstate.NewDatabase("", 0)

pattern := dyn.NewPattern(dyn.Key("resources"), dyn.AnyKey(), dyn.AnyKey())
_, err := dyn.MapByPattern(b.Config.Value(), pattern, func(p dyn.Path, v dyn.Value) (dyn.Value, error) {

@denik denik Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why walk the config and not the actual state? They might not match 1-1.

@shreyas-goenka shreyas-goenka Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To capture the state for both terraform and direct deployments. Most customers are still on terraform so this givess us approximate stats for the state sizes.

@denik denik Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, in that case we should not call StateFileSize, since it has nothing to do with it, we should call it ConfigFileSize.

@shreyas-goenka shreyas-goenka Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does try to approximate the state size - by calling PrepareState:

	target := cfg
	if adapter, ok := adapters[resourceType]; ok {
		state, err := adapter.PrepareState(cfg)
		if err != nil {
			return nil, fmt.Errorf("prepare state: %w", err)
		}
		target = state
	}

	// dstate.SaveState writes resource state with MarshalIndent using these
	// exact prefix/indent arguments; matching them here means each resource's
	// byte length equals len(entry.State) on disk for direct deploys.
	raw, err := json.MarshalIndent(target, "  ", " ")
	if err != nil {
		return nil, fmt.Errorf("marshal: %w", err)
	}
	return raw, nil

denik
denik reviewed Jun 3, 2026
View reviewed changes
Comment thread bundle/phases/resources_metadata.go Outdated
@shreyas-goenka shreyas-goenka requested a review from denik June 3, 2026 15:28
denik
denik reviewed Jun 3, 2026
View reviewed changes
Comment thread bundle/phases/resources_metadata.go Outdated
@shreyas-goenka shreyas-goenka force-pushed the shreyas-goenka/state-size-telemetry branch from 44e4bc0 to d16c208 Compare June 4, 2026 12:39
@shreyas-goenka shreyas-goenka changed the title stats: Record per resource state file statistics in telemetry Track bundle resource state sizes in telemetry (direct engine) Jun 4, 2026
@shreyas-goenka shreyas-goenka force-pushed the shreyas-goenka/state-size-telemetry branch from d16c208 to 1cab854 Compare June 5, 2026 09:55
@shreyas-goenka shreyas-goenka force-pushed the shreyas-goenka/state-size-telemetry branch from 1cab854 to 41cc73a Compare June 8, 2026 12:38
@shreyas-goenka shreyas-goenka requested a review from denik June 8, 2026 12:40
denik
denik reviewed Jun 8, 2026
View reviewed changes
Comment thread acceptance/bundle/telemetry/deploy/test.toml Outdated
Comment thread bundle/phases/resources_metadata.go Outdated
// for sub-resources like permissions / grants / secret_acls. Sub-resources are
// tracked under the sub-resource type so they aggregate across resource
// families. Returns "" for keys that don't match.
func resourceTypeFromKey(key string) string {

@denik denik Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate of

bundle/config/root.go:// GetResourceTypeFromKey extracts the resource group from a resource path.
bundle/config/root.go:func GetResourceTypeFromKey(path string) string {

Comment thread bundle/phases/resources_metadata.go
resources := make([]protos.ResourceMetadata, 0, len(types))
for _, t := range types {
sizes := sizesByType[t]
slices.Sort(sizes)

@denik denik Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to sort to get min/max/mean, it can be done in one pass.

@shreyas-goenka shreyas-goenka Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to sort to get the median though. It's worth getting median (and later maybe P90) since mean does not give a complete picture.

@shreyas-goenka shreyas-goenka force-pushed the shreyas-goenka/state-size-telemetry branch from 41cc73a to 4978c70 Compare June 9, 2026 11:24
@shreyas-goenka
Track bundle resource state sizes in telemetry (direct engine)
d0b2183 
Adds a `resources_metadata` field to the bundle deploy telemetry event with,
per resource type, the count and the max/mean/median state size in bytes, plus
the whole state file size.

Only direct deploys are measured, and collection does no marshalling, file read,
or JSON parsing of its own. The direct engine already serializes each resource's
state during the deploy and reconstructs it via WAL replay in Finalize;
ExportStateFromData now records each entry's len(state) on the ResourceState it
returns. deployCore stashes that finalized state on b.Metrics, and telemetry
reads the per-resource sizes straight off the in-memory map (grouping by
config.GetResourceTypeFromKey). The whole-file size comes from a single os.Stat
(no read/parse). Terraform stores state differently and is not collected (the
field is absent there).

Because the metadata is direct-only it diverges across the
DATABRICKS_BUNDLE_ENGINE test matrix, so the telemetry/deploy test captures it
in a per-engine out.resources_metadata.$DATABRICKS_BUNDLE_ENGINE.txt (terraform:
null) and omits it from the engine-agnostic out.telemetry.txt. Per-resource
sizes are deterministic for a fixed config and asserted exactly (no redaction).
Only state_file_size_bytes is dropped from the golden: it is os.Stat of
resources.json whose header embeds the CLI version string, which differs in
length between linux/macos (0.0.0-dev+<sha>) and windows (0.0.0-dev). It is
still emitted in real telemetry.

The universe proto (resources_metadata, BundleResourcesMetadata,
ResourceMetadata) is already merged, so this is ingested rather than dropped.

Co-authored-by: Isaac
@shreyas-goenka shreyas-goenka force-pushed the shreyas-goenka/state-size-telemetry branch from 4978c70 to d0b2183 Compare June 9, 2026 12:37
@shreyas-goenka shreyas-goenka requested a review from denik June 9, 2026 13:43
@shreyas-goenka shreyas-goenka merged commit 7e85efd into main Jun 9, 2026
31 of 32 checks passed
@shreyas-goenka shreyas-goenka deleted the shreyas-goenka/state-size-telemetry branch June 9, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denik denik denik approved these changes

@pietern pietern Awaiting requested review from pietern

@andrewnester andrewnester Awaiting requested review from andrewnester

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shreyas-goenka @eng-dev-ecosystem-bot @denik