Vector Search follow-up#5367
Open
janniklasrose wants to merge 9 commits into
Open
Conversation
Drop the separate VectorSearchEndpoints.GetEndpointByEndpointName call from DoRead/DoCreate and read endpoint_id directly off the VectorIndex response. This removes the race noted in #5123 where the index's endpoint and the lookup-by-name could disagree if the endpoint was deleted/recreated between the two calls. Won't compile until the SDK gains EndpointId on VectorIndex.
The SDK exposes a dedicated permission level type for vector search endpoints; switch VectorSearchEndpoint.Permissions to use it via the PermissionT[L] generic, matching the typing already in place for jobs, apps, model serving, etc. Regenerated jsonschema.json and added the annotations placeholder for the new VectorSearchEndpointPermission.
Production RemapState already round-trips both fields from the GET response, but the testserver was dropping them. Bring the fake in line with the real backend so acceptance tests see the same shape on read.
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Integration test reportCommit: 8625837
23 interesting tests: 13 SKIP, 7 KNOWN, 3 RECOVERED
Top 6 slowest tests (at least 2 minutes):
|
janniklasrose
changed the title
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
changed the title
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
…search-followup # Conflicts: # bundle/internal/schema/annotations.yml # bundle/schema/jsonschema.json # bundle/schema/jsonschema_for_docs.json
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
Approval status: pending
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
VectorSearchEndpointPermission(backed byvectorsearch.VectorSearchEndpointPermissionLevel) for vector search endpoint permissions, now that the level enum exists upstream, instead of the genericPermissiontype. This gives the endpoint'spermissionsits own distinctly-named JSON schema entry.recreate/name).columns_to_sync/columns_to_indexon VS index reads, and surface the index response's frozenendpoint_idso the fake mirrors the real API surface.createIndexTimeoutcomment link.Note on endpoint UUID handling
An earlier commit switched the index resource to read
endpoint_idoff theVectorIndexresponse instead of looking the endpoint up by name. That was reverted:endpoint_idis frozen at index-creation time, so it can't detect a same-name endpoint being deleted and recreated out of band. The CLI keeps the liveGetEndpointByEndpointNamelookup feeding the state-trackedendpoint_uuid, which is what drives orphan/recreate drift detection (see #5123).endpoint_idremains aREMOTE-only informational field.Why
Follow-ups to #5123.
Tests
Unit tests in
bundle/direct/dresources, plus acceptance tests underacceptance/bundle/resources/vector_search_*(recreate-on-rename, recreate-with-endpoint drift, refschema, schema). All pass locally.This pull request and its description were written by Isaac, an AI coding agent.