Skip to content

acc: Use actual ID replacement for sql warehouse tests #5433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewnester merged 1 commit into from
Jun 4, 2026
Merged

acc: Use actual ID replacement for sql warehouse tests #5433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions acceptance/bundle/resources/sql_warehouses/lifecycle-started-toggle/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ Deployment complete!
}
{
"method": "POST",
"path": "/api/2.0/sql/warehouses/[UUID]/stop",
"path": "/api/2.0/sql/warehouses/[WAREHOUSE_ID]/stop",
"body": {}
}

>>> errcode [CLI] warehouses get [UUID]
>>> errcode [CLI] warehouses get [WAREHOUSE_ID]
"STOPPED"

=== Toggle started=false -> started=true: only Start should be called, no Edit
Expand All @@ -40,11 +40,11 @@ Deployment complete!
>>> print_requests.py //sql/warehouses
{
"method": "POST",
"path": "/api/2.0/sql/warehouses/[UUID]/start",
"path": "/api/2.0/sql/warehouses/[WAREHOUSE_ID]/start",
"body": {}
}

>>> errcode [CLI] warehouses get [UUID]
>>> errcode [CLI] warehouses get [WAREHOUSE_ID]
"RUNNING"

=== Toggle started=true -> started=false: only Stop should be called, no Edit
Expand All @@ -59,11 +59,11 @@ Deployment complete!
>>> print_requests.py //sql/warehouses
{
"method": "POST",
"path": "/api/2.0/sql/warehouses/[UUID]/stop",
"path": "/api/2.0/sql/warehouses/[WAREHOUSE_ID]/stop",
"body": {}
}

>>> errcode [CLI] warehouses get [UUID]
>>> errcode [CLI] warehouses get [WAREHOUSE_ID]
"STOPPED"

>>> [CLI] bundle destroy --auto-approve
Expand Down
1 change: 1 addition & 0 deletions acceptance/bundle/resources/sql_warehouses/lifecycle-started-toggle/script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ trap cleanup EXIT
title "Deploy with started=false: warehouse created and then stopped"
trace errcode $CLI bundle deploy
WAREHOUSE_ID=$($CLI bundle summary -o json | jq -r '.resources.sql_warehouses.mywarehouse.id')
add_repl.py "$WAREHOUSE_ID" "WAREHOUSE_ID"
trace print_requests.py //sql/warehouses
rm -f out.requests.txt
{ trace errcode $CLI warehouses get "$WAREHOUSE_ID" | jq '.state'; } || true
Expand Down
4 changes: 0 additions & 4 deletions acceptance/bundle/resources/sql_warehouses/lifecycle-started-toggle/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,5 @@ RecordRequests = true

Ignore = [".databricks", "databricks.yml"]

[[Repls]]
Old = "[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}"
New = "[UUID]"

[EnvMatrix]
DATABRICKS_BUNDLE_ENGINE = ["direct"]
20 changes: 10 additions & 10 deletions acceptance/bundle/resources/sql_warehouses/lifecycle-started/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ Deployment complete!
}
}

>>> errcode [CLI] warehouses get [UUID]
>>> errcode [CLI] warehouses get [WAREHOUSE_ID]
"RUNNING"

=== Stop warehouse externally while config says started=true: plan detects drift
>>> errcode [CLI] warehouses stop [UUID]
>>> errcode [CLI] warehouses stop [WAREHOUSE_ID]
"STOPPED"

>>> [CLI] bundle plan
Expand All @@ -42,20 +42,20 @@ Deployment complete!
>>> print_requests.py //sql/warehouses
{
"method": "POST",
"path": "/api/2.0/sql/warehouses/[UUID]/stop",
"path": "/api/2.0/sql/warehouses/[WAREHOUSE_ID]/stop",
"body": {}
}
{
"method": "POST",
"path": "/api/2.0/sql/warehouses/[UUID]/start",
"path": "/api/2.0/sql/warehouses/[WAREHOUSE_ID]/start",
"body": {}
}

>>> errcode [CLI] warehouses get [UUID]
>>> errcode [CLI] warehouses get [WAREHOUSE_ID]
"RUNNING"

=== Deploy with started=false while warehouse is stopped: warehouse stays stopped
>>> errcode [CLI] warehouses stop [UUID]
>>> errcode [CLI] warehouses stop [WAREHOUSE_ID]
"STOPPED"

>>> update_file.py databricks.yml started: true started: false
Expand All @@ -69,11 +69,11 @@ Deployment complete!
>>> print_requests.py //sql/warehouses
{
"method": "POST",
"path": "/api/2.0/sql/warehouses/[UUID]/stop",
"path": "/api/2.0/sql/warehouses/[WAREHOUSE_ID]/stop",
"body": {}
}

>>> errcode [CLI] warehouses get [UUID]
>>> errcode [CLI] warehouses get [WAREHOUSE_ID]
"STOPPED"

=== Deploy with started=true: warehouse restarted
Expand All @@ -88,11 +88,11 @@ Deployment complete!
>>> print_requests.py //sql/warehouses
{
"method": "POST",
"path": "/api/2.0/sql/warehouses/[UUID]/start",
"path": "/api/2.0/sql/warehouses/[WAREHOUSE_ID]/start",
"body": {}
}

>>> errcode [CLI] warehouses get [UUID]
>>> errcode [CLI] warehouses get [WAREHOUSE_ID]
"RUNNING"

>>> [CLI] bundle destroy --auto-approve
Expand Down
2 changes: 2 additions & 0 deletions acceptance/bundle/resources/sql_warehouses/lifecycle-started/script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ trap cleanup EXIT
title "Deploy with started=true: warehouse created and running"
trace errcode $CLI bundle deploy
WAREHOUSE_ID=$($CLI bundle summary -o json | jq -r '.resources.sql_warehouses.mywarehouse.id')
add_repl.py "$WAREHOUSE_ID" "WAREHOUSE_ID"

trace print_requests.py //sql/warehouses
rm -f out.requests.txt
{ trace errcode $CLI warehouses get "$WAREHOUSE_ID" | jq '.state'; } || true
Expand Down
4 changes: 0 additions & 4 deletions acceptance/bundle/resources/sql_warehouses/lifecycle-started/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,5 @@ RecordRequests = true

Ignore = [".databricks", "databricks.yml"]

[[Repls]]
Old = "[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}"
New = "[UUID]"

[EnvMatrix]
DATABRICKS_BUNDLE_ENGINE = ["direct"]
Loading