bundle/dms: record display_name on the deployment version#5438
Merged
shreyas-goenka merged 1 commit intoJun 4, 2026
Conversation
Co-authored-by: Isaac
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Jun 4, 2026
shreyas-goenka
merged commit ce81328
into
shreyas-goenka/deployment-metadata-service
23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Set
display_nameon the DMS deployment version, using the bundle name — the same value already recorded on the deployment.The
Versionproto has adisplay_namefield, but theCreateVersionrequest never populated it, so every version came back with a nulldisplay_nameeven though the deployment had one. This stamps it for parity.Why
display_nameis set on the deployment (from the bundle name) but was missing on each version, leaving version records without a human-readable label. Filling it in keeps deployment and version metadata consistent.Tests
Updated the
bundle/dmsacceptance outputs and confirmed they pass.This pull request and its description were written by Isaac, an AI coding agent.