Skip to content

Drive CLI codegen from a checked-in cli.json #5484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pietern wants to merge 8 commits into
base: main
Choose a base branch
from
+198,922 −1,059
Open

Drive CLI codegen from a checked-in cli.json #5484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e500f48
Drive CLI codegen from a checked-in cli.json
pietern Jun 9, 2026
d5673ef
internal/cligen: test splitASCII name-splitting behavior
pietern Jun 9, 2026
e54bc98
internal/cligen: move splitASCII into split.go
pietern Jun 9, 2026
b47043d
internal/cligen: reword split.go header comment
pietern Jun 9, 2026
078472c
internal/cligen: cover the empty/underscore/$ guard branches
pietern Jun 9, 2026
33fe412
codegen: consume the IR-derived cli.json from genkit
pietern Jun 9, 2026
bddbd3c
bundle/internal/schema: drop dead mapIncorrectTypNames
pietern Jun 9, 2026
ea21ed6
Taskfile: minimize diff vs origin/main
pietern Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codegen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"mode": "cli_v0",
"mode": "cli_v1",

@janniklasrose janniklasrose Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we align format in cli.json? There, it's

  "metadata": {
    "generator_version": "cliv1"
  },

@simonfaltum simonfaltum Jun 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on my Taskfile comment about sequencing with a concrete check: genkit on universe master as of 2026-06-09 still has no cli_v1 (codegen.go dispatches cli_v0 only, same in cmd/update and cmd/generate), so genkit update-sdk --dir against this repo fails with unknown mode until the producer merges. Day-to-day task generate is unaffected since cli.json is checked in. Worth noting the minimum universe version in the generate-cli-json comment once the producer lands.

"api_changelog": true,
"formatter": "go run golang.org/x/tools/cmd/goimports@latest -w $FILENAMES && go fmt ./...",
"version": {
Expand Down
1 change: 1 addition & 0 deletions .codegen/.gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
cli.json linguist-generated=true
Loading
Loading