ci: stop canceling PR approval workflow runs#5566
Merged
Merged
Conversation
The PR approval workflow grouped every run for a PR under one concurrency key with cancel-in-progress: true, so an in-flight run (e.g. from a push) was canceled when a newer event (e.g. an approval) arrived; a canceled run posts its own `check` check-run with a cancelled conclusion, and because GitHub records one check-run per workflow run rather than one per name, the later successful run posts a separate green check-run instead of clearing the red one, so the commit stays red until that run is re-run or a new commit supersedes it. cancel-in-progress: false would not fix it because concurrency also cancels pending runs by default, so the only way to never cancel a run is to drop the concurrency block entirely; the check is idempotent and ~20s, so letting every run finish is harmless and the gate status still lands on the head commit via the latest run. Co-authored-by: Isaac
Collaborator
|
Commit: b458b83
25 interesting tests: 15 SKIP, 7 flaky, 3 RECOVERED
Top 32 slowest tests (at least 2 minutes):
|
simonfaltum
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PR approvalworkflow canceled in-flight runs via concurrency (cancel-in-progress: true). A canceled run leaves its own failingcheckcheck-run, and since GitHub keeps one check-run per run rather than per name, a later passing run doesn't clear it — the commit stays red until that run is re-run.cancel-in-progress: falsewouldn't be enough, since concurrency also cancels pending runs by default, so this drops the block entirely; the check is idempotent and ~20s, so letting every run finish is harmless.Found while investigating a stray red ✗ on an unrelated PR that lingered even after the same workflow had passed.
This pull request and its description were written by Isaac.