Route sandbox CLI reviews through team:eng-sandbox#5567
Merged
Conversation
The eng-sandbox GitHub team now exists and is the right grain for sandbox CLI ownership going forward; individual @-mentions get stale as the team rotates. Co-authored-by: Isaac
akshaysingla-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
akshaysingla-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
The maintainer-approval workflow can't resolve org team membership via GITHUB_TOKEN, so the team aliases used in OWNERS need a static roster here. Mirror the current eng-sandbox GitHub team. Co-authored-by: Isaac
akshaysingla-db
changed the title
akshaysingla-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
akshaysingla-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
changed the title
pietern
approved these changes
Jun 12, 2026
Collaborator
|
Commit: 4152326
24 interesting tests: 15 SKIP, 6 RECOVERED, 3 flaky
Top 29 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 3dc5667
391 interesting tests: 339 MISS, 32 FAIL, 11 KNOWN, 4 PANIC, 2 flaky, 2 SKIP, 1 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eng-sandboxGitHub team now exists (databricks/teams/eng-sandbox) and is the right grain for sandbox CLI ownership.team:eng-sandboxroster to.github/OWNERTEAMS— the maintainer-approval workflow can't resolve GitHub team membership viaGITHUB_TOKEN, so this file is the source of truth and has to mirror the team's actual roster./cmd/sandbox/and/acceptance/cmd/sandbox/rules in.github/OWNERSfrom individual @-mentions toteam:eng-sandboxso reviews route through the team as it rotates.Test plan
git diffconfirms only the two sandbox rules and the new roster line change; every other section is untouched.gh api /orgs/databricks/teams/eng-sandbox/members).team:platform/team:bundle/team:eng-apps-devex.This pull request and its description were written by Isaac.