Skip to content

acceptance: also set HTTP_PROXY to block plain-HTTP external calls #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denik wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

acceptance: also set HTTP_PROXY to block plain-HTTP external calls #5596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions acceptance/acceptance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,8 +779,9 @@ func runTest(t *testing.T,
// it immediately clear which test caused the internet access.
proxyURL = internal.StartRejectingProxy(t, "")
}
// Only block HTTPS: the local test server is plain HTTP (http://127.0.0.1:PORT)
// so HTTP_PROXY would intercept its traffic. All real external calls use HTTPS.
// Block both HTTP and HTTPS external traffic. NO_PROXY below exempts the
// local test server (http://127.0.0.1:PORT) so its traffic is not intercepted.
cmd.Env = append(cmd.Env, "HTTP_PROXY="+proxyURL)
cmd.Env = append(cmd.Env, "HTTPS_PROXY="+proxyURL)
// Python's urllib does not automatically bypass the proxy for loopback
// addresses the way Go does, so the test-server helper scripts
Expand Down
Loading