Add invariant config coverage test#5779
Merged
Merged
Conversation
janniklasrose
approved these changes
Jun 30, 2026
pietern
approved these changes
Jun 30, 2026
| } | ||
|
|
||
| // TestInvariantConfigsCoverage ensures that the invariant test configs in | ||
| // bundle/invariant/configs cover every bundle resource type, and that resource |
Contributor
There was a problem hiding this comment.
We should put this under acceptance/bundle/....
Contributor
Author
There was a problem hiding this comment.
not sure if we should mix acceptance tests and go tests in one directory and bundle/ only has acceptance tests today.
Contributor
There was a problem hiding this comment.
Feels like a smell to keep this at the top level. Any other options?
Check that every bundle resource type has an invariant config, and that resources supporting permissions/grants have at least one config exercising them. Known gaps are tracked in an explicit allowlist that can only shrink. Co-authored-by: Isaac
Co-authored-by: Isaac
After rebase, model_serving_endpoints and database_instances gained permission configs on main; the coverage check requires removing them. Co-authored-by: Isaac
denik
force-pushed
the
denik/invariant-check
branch
from
a3b859a to
f318d86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Ensure that all resource have invariant test coverage. Recent example where lack of coverage caused to release a bug in migrate rewrite #5775