-
Notifications
You must be signed in to change notification settings - Fork 191
Dry-run migration to direct engine after terraform deploy #5797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a3ef786
Dry-run migration to direct engine after terraform deploy
denik aa1a93f
Address review: temp-file dry-run, prefixed warnings, bool telemetry
denik d4c595e
acceptance: capture dry-run migration telemetry per-engine
denik f1e4c67
Add feedback notice, compact per-engine telemetry snapshots
denik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
acceptance/bundle/resource_deps/job_tasks/out.telemetry.terraform.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
acceptance/bundle/resource_deps/resources_var/out.telemetry.direct.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| dms_compat_auto true | ||
| dms_undeclared_deploying_user false | ||
| dms_undeclared_group false | ||
| dms_undeclared_other_user false | ||
| dms_undeclared_service_principal false | ||
| experimental.use_legacy_run_as false | ||
| has_classic_interactive_compute false | ||
| has_classic_job_compute false | ||
| has_serverless_compute false | ||
| local.cache.attempt true | ||
| local.cache.hit true | ||
| permissions_section_set false | ||
| presets_name_prefix_is_set true | ||
| python_wheel_wrapper_is_set false | ||
| run_as_set false | ||
| skip_artifact_cleanup false | ||
| state_path_in_deployer_home true | ||
| state_path_in_other_user_home false | ||
| state_path_is_shared false | ||
| state_path_other false |
22 changes: 22 additions & 0 deletions
22
acceptance/bundle/resource_deps/resources_var/out.telemetry.terraform.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| direct_drymigrate_success true | ||
| direct_drymigrate_warnings false | ||
| dms_compat_auto true | ||
| dms_undeclared_deploying_user false | ||
| dms_undeclared_group false | ||
| dms_undeclared_other_user false | ||
| dms_undeclared_service_principal false | ||
| experimental.use_legacy_run_as false | ||
| has_classic_interactive_compute false | ||
| has_classic_job_compute false | ||
| has_serverless_compute false | ||
| local.cache.attempt true | ||
| local.cache.hit true | ||
| permissions_section_set false | ||
| presets_name_prefix_is_set true | ||
| python_wheel_wrapper_is_set false | ||
| run_as_set false | ||
| skip_artifact_cleanup false | ||
| state_path_in_deployer_home true | ||
| state_path_in_other_user_home false | ||
| state_path_is_shared false | ||
| state_path_other false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
acceptance/bundle/resource_deps/tf_path_only_error/out.telemetry.terraform.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
164 changes: 164 additions & 0 deletions
164
acceptance/bundle/telemetry/deploy-compute-type/out.bool_values.direct.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,164 @@ | ||
| [ | ||
| { | ||
| "key": "local.cache.attempt", | ||
| "value": true | ||
| }, | ||
| { | ||
| "key": "local.cache.miss", | ||
| "value": true | ||
| }, | ||
| { | ||
| "key": "experimental.use_legacy_run_as", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "run_as_set", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "presets_name_prefix_is_set", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "python_wheel_wrapper_is_set", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "skip_artifact_cleanup", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "state_path_is_shared", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "permissions_section_set", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "state_path_in_deployer_home", | ||
| "value": true | ||
| }, | ||
| { | ||
| "key": "state_path_in_other_user_home", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "state_path_other", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "dms_undeclared_deploying_user", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "dms_undeclared_other_user", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "dms_undeclared_service_principal", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "dms_undeclared_group", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "dms_compat_auto", | ||
| "value": true | ||
| }, | ||
| { | ||
| "key": "has_serverless_compute", | ||
| "value": true | ||
| }, | ||
| { | ||
| "key": "has_classic_job_compute", | ||
| "value": true | ||
| }, | ||
| { | ||
| "key": "has_classic_interactive_compute", | ||
| "value": true | ||
| } | ||
| ] | ||
| [ | ||
| { | ||
| "key": "local.cache.attempt", | ||
| "value": true | ||
| }, | ||
| { | ||
| "key": "local.cache.hit", | ||
| "value": true | ||
| }, | ||
| { | ||
| "key": "experimental.use_legacy_run_as", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "run_as_set", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "presets_name_prefix_is_set", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "python_wheel_wrapper_is_set", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "skip_artifact_cleanup", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "state_path_is_shared", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "permissions_section_set", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "state_path_in_deployer_home", | ||
| "value": true | ||
| }, | ||
| { | ||
| "key": "state_path_in_other_user_home", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "state_path_other", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "dms_undeclared_deploying_user", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "dms_undeclared_other_user", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "dms_undeclared_service_principal", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "dms_undeclared_group", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "dms_compat_auto", | ||
| "value": true | ||
| }, | ||
| { | ||
| "key": "has_serverless_compute", | ||
| "value": true | ||
| }, | ||
| { | ||
| "key": "has_classic_job_compute", | ||
| "value": false | ||
| }, | ||
| { | ||
| "key": "has_classic_interactive_compute", | ||
| "value": false | ||
| } | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.