acc: run bundle/artifacts/artifact_path_with_volume locally#5940
Merged
Conversation
The two subtests (volume_doesnot_exist, volume_not_deployed) already run locally via their own Local = true overrides; only the group's parent test.toml still defaulted to Local = false. Flip it to Local = true so the default matches how the tests actually run and no stale cloud-only default remains. RecordRequests = false stays: it intentionally overrides the RecordRequests = true set by the artifacts parent test.toml.
radakam
marked this pull request as ready for review
July 16, 2026 09:52
Collaborator
Integration test reportCommit: d4e35ef
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 10 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Jul 16, 2026
pietern
reviewed
Jul 16, 2026
| @@ -1,3 +1,3 @@ | |||
| Local = false | |||
| Local = true | |||
Contributor
There was a problem hiding this comment.
Can we omit the Local setting in the nested configs now?
Contributor
Author
There was a problem hiding this comment.
Yes, thanks for noticing! Cleaned it up a bit further -- dropped Local and Cloud from the nested configs and moved RequiresUnityCatalog to the parent.
…parent Addressing review feedback: with the parent defaulting to Local = true, the nested configs no longer need to repeat Local (or Cloud, also set by the parent). Move the shared RequiresUnityCatalog = true up to the parent too, which empties volume_doesnot_exist/test.toml (removed) and leaves volume_not_deployed with just its Badness note. Resolved config is unchanged.
radakam
enabled auto-merge
July 16, 2026 10:58
Collaborator
Integration test reportCommit: b6cf22b
22 interesting tests: 10 flaky, 6 FAIL, 3 RECOVERED, 2 SKIP, 1 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
volume_doesnot_exist,volume_not_deployed) already run locally via their ownLocal = trueoverrides; only the group's parenttest.tomlstill defaulted toLocal = false.Local = trueso the default matches how the tests actually run and no stale cloud-only default remains.RecordRequests = falsestays: it intentionally overrides theRecordRequests = trueset by the artifacts parenttest.toml.