acc: run ssh/connect-serverless-cpu locally#5941
Merged
Merged
Conversation
Mirror the connect-serverless-gpu local conversion for the bare `ssh connect` (serverless CPU) invocation: run against the in-process testserver, which backs the driver-proxy /ssh websocket with a real sshd, so the run asserts both the submitted bootstrap job and a full handshake + remote exec over the ws:// tunnel. Linux-only and skipped when sshd is absent, matching the sibling ssh tests. Unlike the GPU test, the CPU invocation passes no --name, so the CLI derives the connection name from a hash of the workspace host. That host is a random localhost port locally, so a Repls entry normalizes databricks-cpu-<hash> to keep the submitted job payload deterministic. The cloud branch (Connection successful over real serverless CPU) is preserved for when cloud is re-enabled.
Collaborator
Integration test reportCommit: 7ffc996
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 10 slowest tests (at least 2 minutes):
|
radakam
marked this pull request as ready for review
July 16, 2026 10:34
| echo "SKIP_TEST sshd (openssh-server) not installed" | ||
| exit 0 | ||
| fi | ||
| errcode $CLI ssh connect --releases-dir=$CLI_RELEASES_DIR --user-known-hosts-file=known_hosts -- "echo 'Connection successful'" >out.stdout.txt 2>LOG.stderr |
Contributor
There was a problem hiding this comment.
would be good to have the core of this test CLI ssh connect traced and/or titled. optional args could be set based on env
Contributor
Author
There was a problem hiding this comment.
Added a title "CLI ssh connect ..." so the core command shows up in the golden output, but left the actual invocation on errcode + redirect rather than trace because its stdout/stderr are non-deterministic.
Merge the two CLOUD_ENV conditionals so the local setup lives in one branch, replace the ': >file' idiom with touch, and title the core 'ssh connect' command so it surfaces in the golden output.
anton-107
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Local = true/Cloud = false. The baressh connect(serverless CPU) now runs against the in-process testserver, whose driver-proxy/sshwebsocket is backed by a realsshd— so the test asserts both the submitted bootstrap job and a full handshake + remote exec over the tunnel.[GOOS]), skipped whensshdis absent, matching the sibling SSH tests.Replsfordatabricks-cpu-<hash>: with no--name, the connection name is derived from a hash of the workspace host (a random localhost port locally), so it's normalized to keep the submitted job payload deterministic.CLOUD_ENVbranch so the real serverless-CPU path is preserved for when cloudssh connectis re-enabled.Why
Cloud = falsereflects that cloudssh connectis currently disabled (#4838); the real coverage now comes from the local run. Consistent withconnect-serverless-gpuandconnection.