You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix backtick quoting for column names in batched INSERT reconstruction (#1285)
## Summary
- `generateMultiRowInsert()` now wraps column names with backticks when
reconstructing multi-row INSERT SQL
- This fixes `PARSE_SYNTAX_ERROR` for column names containing dots
(e.g., `col.name`) when `EnableBatchedInserts` is enabled
- Added test case for dotted column names
## Root Cause
`parseColumns()` strips backticks from column names, but
`generateMultiRowInsert()` joins them back without re-quoting. Unquoted
column names containing dots are then interpreted as schema/table
separators by the SQL parser.
## Test plan
- [x] Existing `InsertStatementParserTest` tests updated and passing
(18/18)
- [x] New `testGenerateMultiRowInsertWithDottedColumnNames` test added
Fixes#1284
---------
Signed-off-by: Oleksandr Shevchenko <oleksandr.shevchenko@datarobot.com>
Co-authored-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Copy file name to clipboardExpand all lines: NEXT_CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -8,6 +8,7 @@
8
8
9
9
### Fixed
10
10
- Fixed primitive types within complex types (ARRAY, MAP, STRUCT) not being correctly parsed when Arrow serialization uses alternate formats: TIMESTAMP/TIMESTAMP_NTZ as epoch microseconds or component arrays, and BINARY as base64-encoded strings.
11
+
- Fixed `PARSE_SYNTAX_ERROR` for column names containing special characters (e.g., dots) when `EnableBatchedInserts` is enabled, by re-quoting column names with backticks in reconstructed multi-row INSERT statements.
11
12
12
13
---
13
14
*Note: When making changes, please add your change under the appropriate section
0 commit comments