Commit 19b854d
Suggestion: modify tinyint to string conversion (#1053)
## Description
Currently the conversion from tinyint to string is done using
`String(byte[])` which depends on the platform's default charset and
also is
[unspecified](https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#String-byte:A-)
when the bytes are not valid in the default charset (e.g. may produce
"?" instead of a sensible value).
## Testing
Tested with the existing unit tests.
## Additional Notes to the Reviewer
-
---------
Signed-off-by: Ivan Vankov <ivan.vankov@workato.com>
Co-authored-by: Samikshya Chand <148681192+samikshya-db@users.noreply.github.com>1 parent e32739b commit 19b854d
3 files changed
Lines changed: 8 additions & 4 deletions
File tree
- src
- main/java/com/databricks/jdbc/api/impl/converters
- test/java/com/databricks/jdbc/api/impl/converters
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| |||
74 | 76 | | |
75 | 77 | | |
76 | 78 | | |
77 | | - | |
78 | | - | |
79 | | - | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
80 | 83 | | |
81 | 84 | | |
82 | 85 | | |
| |||
0 commit comments