Skip to content

Commit 538182a

Browse files
authored
exclude m2m tests in pr checks (#876)
* exclude m2m tests in pr checks * exclude m2m tests on PR run * removed getJwtTokenEndpoint method
1 parent 8b92a4a commit 538182a

6 files changed

Lines changed: 8 additions & 3 deletions

File tree

.github/workflows/prIntegrationTests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
matrix:
1616
include:
17-
- test-command: mvn -B compile test -Dtest=*IntegrationTests
17+
- test-command: mvn -B compile test -Dtest=*IntegrationTests,!M2MPrivateKeyCredentialsIntegrationTests,!M2MAuthIntegrationTests
1818
fake-service-type: 'SQL_EXEC'
1919
- test-command: mvn -B compile test -Dtest=*IntegrationTests,!M2MPrivateKeyCredentialsIntegrationTests,!SqlExecApiHybridResultsIntegrationTests,!DBFSVolumeIntegrationTests,!M2MAuthIntegrationTests,!UCVolumeIntegrationTests
2020
fake-service-type: 'THRIFT_SERVER'

src/test/java/com/databricks/jdbc/integration/fakeservice/AbstractFakeServiceIntegrationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package com.databricks.jdbc.integration.fakeservice;
22

3-
import static com.databricks.jdbc.integration.IntegrationTestUtil.getJWTTokenEndpointHost;
43
import static com.databricks.jdbc.integration.fakeservice.FakeServiceConfigLoader.CLOUD_FETCH_HOST_PROP;
54
import static com.databricks.jdbc.integration.fakeservice.FakeServiceConfigLoader.DATABRICKS_HOST_PROP;
5+
import static com.databricks.jdbc.integration.fakeservice.FakeServiceConfigLoader.JWT_TOKEN_ENDPOINT_HOST_PROP;
66
import static com.github.tomakehurst.wiremock.core.WireMockConfiguration.wireMockConfig;
77

88
import com.databricks.jdbc.common.DatabricksJdbcConstants;
@@ -73,7 +73,7 @@ public abstract class AbstractFakeServiceIntegrationTests {
7373
new FakeServiceHttpClientFactory(
7474
FakeServiceConfigLoader.getFakeServiceUserAgent()))),
7575
DatabricksJdbcConstants.FakeServiceType.JWT_TOKEN_ENDPOINT,
76-
getJWTTokenEndpointHost());
76+
FakeServiceConfigLoader.getProperty(JWT_TOKEN_ENDPOINT_HOST_PROP));
7777

7878
/**
7979
* Resets the potential mutations (e.g., URLs set by {@link #setDatabricksApiTargetUrl}, {@link

src/test/java/com/databricks/jdbc/integration/fakeservice/FakeServiceConfigLoader.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ public class FakeServiceConfigLoader {
1313

1414
public static final String PRESIGNED_URL_HOST = "host.presignedurl";
1515

16+
public static final String JWT_TOKEN_ENDPOINT_HOST_PROP = "host.jwt.token.endpoint";
17+
1618
public static final String TEST_CATALOG = "testcatalog";
1719

1820
public static final String TEST_SCHEMA = "testschema";

src/test/resources/sqlexecfakeservicetest.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
host.databricks=https://e2-dogfood.staging.cloud.databricks.com:443
22
host.cloudfetch=https://e2-dogfood-core.s3.us-west-2.amazonaws.com
33
host.presignedurl=https://us-west-2-extstaging-managed-catalog-test-bucket-1.s3-fips.us-west-2.amazonaws.com
4+
host.jwt.token.endpoint=https://dev-591123.oktapreview.com
45
# SQL warehouse compute
56
httppath=/sql/1.0/warehouses/dd43ee29fedd958d
67
connschema=default

src/test/resources/sqlgatewayfakeservicetest.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
host.databricks=https://e2-dogfood.staging.cloud.databricks.com:443
22
host.cloudfetch=https://e2-dogfood-core.s3.us-west-2.amazonaws.com
3+
host.jwt.token.endpoint=https://dev-591123.oktapreview.com
34
# SQL warehouse compute
45
httppath=/sql/1.0/warehouses/dd43ee29fedd958d
56
connschema=default

src/test/resources/thriftserverfakeservicetest.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
host.databricks=https://e2-dogfood.staging.cloud.databricks.com:443
22
host.cloudfetch=https://e2-dogfood-core.s3.us-west-2.amazonaws.com
3+
host.jwt.token.endpoint=https://dev-591123.oktapreview.com
34
# All-purpose compute
45
httppath=/sql/protocolv1/o/6051921418418893/0819-204509-hill72
56
connschema=default

0 commit comments

Comments
 (0)