Commit 717cc27
Force runAsync=false for metadata SHOW commands in Thrift client (#1258)
## Summary
- Metadata SHOW commands routed through `executeStatement()` via
`UseQueryForMetadata` were incorrectly executing asynchronously because
`getRequest()` always forces `runAsync=true` in production
- Added `StatementType` parameter to `getRequest()` and skip the
`runAsync=true` override when `statementType == METADATA`, aligning
Thrift client behavior with the SEA client
- Updated existing test expectations and added new tests verifying
`runAsync` is `false` for METADATA and `true` for SQL statements
## Test plan
- [x] `DatabricksThriftServiceClientTest` — 43 tests pass (includes 2
new tests)
- [x] `DatabricksMetadataQueryClientTest` — 44 tests pass
- [x] `DatabricksSessionTest` — 17 tests pass
- [ ] Verify metadata SHOW commands execute synchronously in production
with `UseQueryForMetadata` enabled
🤖 Generated with [Claude Code](https://claude.com/claude-code)
NO_CHANGELOG=true
---------
Signed-off-by: Gopal Lal <gopal.lal@databricks.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>1 parent 0531451 commit 717cc27
2 files changed
Lines changed: 70 additions & 5 deletions
File tree
- src
- main/java/com/databricks/jdbc/dbclient/impl/thrift
- test/java/com/databricks/jdbc/dbclient/impl/thrift
Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
| 166 | + | |
166 | 167 | | |
167 | 168 | | |
168 | 169 | | |
| |||
181 | 182 | | |
182 | 183 | | |
183 | 184 | | |
184 | | - | |
| 185 | + | |
| 186 | + | |
185 | 187 | | |
186 | 188 | | |
187 | 189 | | |
| |||
204 | 206 | | |
205 | 207 | | |
206 | 208 | | |
207 | | - | |
| 209 | + | |
| 210 | + | |
208 | 211 | | |
209 | 212 | | |
210 | 213 | | |
| |||
254 | 257 | | |
255 | 258 | | |
256 | 259 | | |
257 | | - | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
258 | 263 | | |
259 | 264 | | |
260 | 265 | | |
| |||
Lines changed: 61 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
707 | 707 | | |
708 | 708 | | |
709 | 709 | | |
| 710 | + | |
710 | 711 | | |
711 | | - | |
712 | 712 | | |
713 | 713 | | |
714 | 714 | | |
| |||
1055 | 1055 | | |
1056 | 1056 | | |
1057 | 1057 | | |
| 1058 | + | |
| 1059 | + | |
| 1060 | + | |
| 1061 | + | |
| 1062 | + | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
| 1072 | + | |
| 1073 | + | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
1058 | 1118 | | |
1059 | 1119 | | |
1060 | 1120 | | |
| |||
0 commit comments